From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: rashmica.g@gmail.com, anton@samba.org
Subject: Re: powerpc/powernv: Fix memtrace build when NUMA=n
Date: Wed, 16 May 2018 23:38:48 +1000 (AEST) [thread overview]
Message-ID: <40mFrm49N5z9s4r@ozlabs.org> (raw)
In-Reply-To: <20180510130913.23931-1-mpe@ellerman.id.au>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Thu, 2018-05-10 at 13:09:13 UTC, Michael Ellerman wrote:
> Currently memtrace doesn't build if NUMA=n:
>
> In function ‘memtrace_alloc_node’:
> arch/powerpc/platforms/powernv/memtrace.c:134:6:
> error: the address of ‘contig_page_data’ will always evaluate as ‘true’
> if (!NODE_DATA(nid) || !node_spanned_pages(nid))
> ^
>
> This is because for NUMA=n NODE_DATA(nid) points to an always
> allocated structure, contig_page_data.
>
> But even in the NUMA=y case memtrace_alloc_node() is only called for
> online nodes, and we should always have a NODE_DATA() allocated for an
> online node. So remove the (hopefully) overly paranoid check, which
> also means we can build when NUMA=n.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/8ccb442dec0ab53eefb5a607e405f7
cheers
prev parent reply other threads:[~2018-05-16 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 13:09 [PATCH] powerpc/powernv: Fix memtrace build when NUMA=n Michael Ellerman
2018-05-16 13:38 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40mFrm49N5z9s4r@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rashmica.g@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).