From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: alistair@popple.id.au, paulus@samba.org
Subject: Re: [1/3] powerpc/io: Add __raw_writeq_be() __raw_rm_writeq_be()
Date: Mon, 21 May 2018 20:01:24 +1000 (AEST) [thread overview]
Message-ID: <40qDnd0rtdz9s3D@ozlabs.org> (raw)
In-Reply-To: <20180514125033.12000-1-mpe@ellerman.id.au>
On Mon, 2018-05-14 at 12:50:31 UTC, Michael Ellerman wrote:
> Add byte-swapping versions of __raw_writeq() and __raw_rm_writeq().
>
> This allows us to avoid sparse warnings caused by passing __be64 to
> __raw_writeq(), which takes unsigned long:
>
> arch/powerpc/platforms/powernv/pci-ioda.c:1981:38:
> warning: incorrect type in argument 1 (different base types)
> expected unsigned long [unsigned] v
> got restricted __be64 [usertype] <noident>
>
> It's also generally preferable to use a byte-swapping accessor rather
> than doing it by hand in the code, which is more bug prone.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Reviewed-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Series applied to powerpc next.
https://git.kernel.org/powerpc/c/8056fe28d04607106e7d418bd9ee2e
cheers
prev parent reply other threads:[~2018-05-21 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 12:50 [PATCH 1/3] powerpc/io: Add __raw_writeq_be() __raw_rm_writeq_be() Michael Ellerman
2018-05-14 12:50 ` [PATCH 2/3] powerpc/powernv: Use __raw_[rm_]writeq_be() in pci-ioda.c Michael Ellerman
2018-05-14 12:50 ` [PATCH 3/3] powerpc/powernv: Use __raw_[rm_]writeq_be() in npu-dma.c Michael Ellerman
2018-05-18 6:39 ` [PATCH 1/3] powerpc/io: Add __raw_writeq_be() __raw_rm_writeq_be() Samuel Mendoza-Jonas
2018-05-18 12:00 ` Michael Ellerman
2018-05-21 10:01 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40qDnd0rtdz9s3D@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=alistair@popple.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).