From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40skqR5dCDzF1lS for ; Fri, 25 May 2018 21:41:39 +1000 (AEST) In-Reply-To: <20180423193638.10535-1-malat@debian.org> To: Mathieu Malaterre From: Michael Ellerman Cc: Mathieu Malaterre , Randy Dunlap , linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [v2] powerpc/mm/radix: use do/while(0) trick for single statement block Message-Id: <40skqR2pvmz9s4V@ozlabs.org> Date: Fri, 25 May 2018 21:41:39 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2018-04-23 at 19:36:38 UTC, Mathieu Malaterre wrote: > In commit 7a22d6321c3d ("powerpc/mm/radix: Update command line parsing for > disable_radix") an `if` statement was added for a possible empty body > (prom_debug). > > Fix the following warning, treated as error with W=1: > > arch/powerpc/kernel/prom_init.c:656:46: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body] > > Suggested-by: Randy Dunlap > Signed-off-by: Mathieu Malaterre > Acked-by: Randy Dunlap Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/85aa4b98419d74dd5cc914e0893498 cheers