From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Cc: maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
anju@linux.vnet.ibm.com
Subject: Re: [v2,1/4] powerpc/perf: Rearrange memory freeing in imc init
Date: Tue, 5 Jun 2018 00:11:01 +1000 (AEST) [thread overview]
Message-ID: <40zxgC0BYwz9s4n@ozlabs.org> (raw)
In-Reply-To: <1526980357-25385-2-git-send-email-anju@linux.vnet.ibm.com>
On Tue, 2018-05-22 at 09:12:34 UTC, Anju T Sudhakar wrote:
> When any of the IMC (In-Memory Collection counter) devices fail
> to initialize, imc_common_mem_free() frees set of memory. In doing so,
> pmu_ptr pointer is also freed. But pmu_ptr pointer is used in subsequent
> function (imc_common_cpuhp_mem_free()) which is wrong. Patch here reorders
> the code to avoid such access.
>
> Also free the memory which is dynamically allocated during imc
> initialization, wherever required.
>
> Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
> Reviewed-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/cb094fa5af7c9623084aa4c3cf529b
cheers
next prev parent reply other threads:[~2018-06-04 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 9:12 [PATCH v2 0/4] powerpc/perf: IMC Cleanups Anju T Sudhakar
2018-05-22 9:12 ` [PATCH v2 1/4] powerpc/perf: Rearrange memory freeing in imc init Anju T Sudhakar
2018-06-04 14:11 ` Michael Ellerman [this message]
2018-05-22 9:12 ` [PATCH v2 2/4] powerpc/perf: Replace the direct return with goto statement Anju T Sudhakar
2018-05-22 9:12 ` [PATCH v2 3/4] powerpc/perf: Return appropriate value for unknown domain Anju T Sudhakar
2018-05-22 9:12 ` [PATCH v2 4/4] powerpc/perf: Unregister thread-imc if core-imc not supported Anju T Sudhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40zxgC0BYwz9s4n@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=anju@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).