From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@ozlabs.org, viro@zeniv.linux.org.uk
Cc: malat@debian.org
Subject: Re: powerpc/ptrace: Use copy_{from, to}_user() rather than open-coding
Date: Tue, 5 Jun 2018 00:11:15 +1000 (AEST) [thread overview]
Message-ID: <40zxgV5SmWz9s7Q@ozlabs.org> (raw)
In-Reply-To: <20180529125738.24271-1-mpe@ellerman.id.au>
On Tue, 2018-05-29 at 12:57:38 UTC, Michael Ellerman wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
>
> In PPC_PTRACE_GETHWDBGINFO and PPC_PTRACE_SETHWDEBUG we do an
> access_ok() check and then __copy_{from,to}_user().
>
> Instead we should just use copy_{from,to}_user() which does all that
> for us and is less error prone.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Reviewed-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/6bcdd2972b9f6ebda9ae5c7075e2d5
cheers
prev parent reply other threads:[~2018-06-04 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 12:57 [PATCH] powerpc/ptrace: Use copy_{from, to}_user() rather than open-coding Michael Ellerman
2018-05-30 6:48 ` Samuel Mendoza-Jonas
2018-06-04 14:11 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40zxgV5SmWz9s7Q@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=malat@debian.org \
--cc=mpe@ellerman.id.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).