From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40zxgX5C8fzF0dd for ; Tue, 5 Jun 2018 00:11:20 +1000 (AEST) In-Reply-To: <20180529125738.24271-1-mpe@ellerman.id.au> To: Michael Ellerman , linuxppc-dev@ozlabs.org, viro@zeniv.linux.org.uk From: Michael Ellerman Cc: malat@debian.org Subject: Re: powerpc/ptrace: Use copy_{from, to}_user() rather than open-coding Message-Id: <40zxgV5SmWz9s7Q@ozlabs.org> Date: Tue, 5 Jun 2018 00:11:15 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2018-05-29 at 12:57:38 UTC, Michael Ellerman wrote: > From: Al Viro > > In PPC_PTRACE_GETHWDBGINFO and PPC_PTRACE_SETHWDEBUG we do an > access_ok() check and then __copy_{from,to}_user(). > > Instead we should just use copy_{from,to}_user() which does all that > for us and is less error prone. > > Signed-off-by: Al Viro > Signed-off-by: Michael Ellerman > Reviewed-by: Samuel Mendoza-Jonas Applied to powerpc next. https://git.kernel.org/powerpc/c/6bcdd2972b9f6ebda9ae5c7075e2d5 cheers