From: Corey Minyard <minyard@acm.org>
To: Kumar Gala <kumar.gala@freescale.com>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: Patch for debug setcontext
Date: Thu, 29 Jul 2004 10:58:37 -0500 [thread overview]
Message-ID: <41091EAD.8010302@acm.org> (raw)
In-Reply-To: <41090F9A.8000901@mvista.com>
I misspoke a little. Consider the following code in entry.S:
#ifdef CONFIG_4xx
/* Check whether this process has its own DBCR0 value */
lwz r0,PTRACE(r2)
andi. r0,r0,PT_PTRACED
bnel- load_4xx_dbcr0
#endif
Do we need to add the book E define to this, too?
-Corey
Corey Minyard wrote:
>
> Kumar Gala wrote:
>
> > I'm guessing, this should really be #if defined(CONFIG_4xx) ||
> > defined(CONFIG_BOOKE)
> > There are a number of similar cases later in this code as well.
>
> That may be the case, but it is very confusing in entry.S. The dbcr0
> register seems to only be defined on 4xx processor, not on book E.
> Look, for instance, at load_4xx_dbcr0:, it is only defined if 4xx is
> enabled, not if book E is enabled.
>
> -Corey
>
>
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-07-29 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-29 14:54 Patch for debug setcontext Corey Minyard
2004-07-29 15:58 ` Corey Minyard [this message]
2004-07-29 19:30 ` Kumar Gala
2004-07-30 2:27 ` Corey Minyard
2004-07-30 14:08 ` Kumar Gala
2004-08-06 21:39 ` Patch for debug setcontext, relative to 2.6.8 Corey Minyard
-- strict thread matches above, loose matches on Subject: below --
2004-07-28 4:09 Patch for debug setcontext Corey Minyard
2004-07-28 13:52 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41091EAD.8010302@acm.org \
--to=minyard@acm.org \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).