From: Segher Boessenkool <segher@kernel.crashing.org>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Harry Ciao <qingtao.cao@windriver.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 1/2] Maple: register CPC925 EDAC device on all boards with CPC925
Date: Mon, 23 May 2011 17:40:40 +0200 [thread overview]
Message-ID: <41281836ef63fbd23f9f01cee34078bc@kernel.crashing.org> (raw)
In-Reply-To: <1306059295-25806-1-git-send-email-dbaryshkov@gmail.com>
> Currently Maple setup code creates cpc925_edac device only on
> Motorola ATCA-6101 blade. Make setup code check bridge revision
> and enable EDAC on all U3H bridges.
>
> Verified on Momentum MapleD (ppc970fx kit) board.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Acked-by: Segher Boessenkool <segher@kernel.crashing.org>
One tiny thing:
> + if (rev >= 0x34 && rev <= 0x3f) { /* U3H */
> + printk(KERN_ERR "%s: Non-CPC925(U3H) bridge revision: %02x\n",
> + __func__, rev);
> + return -ENODEV;
> + }
That's not really an error, is it?
Segher
prev parent reply other threads:[~2011-05-23 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 10:14 [PATCH V2 1/2] Maple: register CPC925 EDAC device on all boards with CPC925 Dmitry Eremin-Solenikov
2011-05-22 10:14 ` [PATCH V2 2/2] cpc925_edac: support single-processor configurations Dmitry Eremin-Solenikov
2011-05-23 15:50 ` Segher Boessenkool
2011-05-23 15:40 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41281836ef63fbd23f9f01cee34078bc@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dbaryshkov@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=qingtao.cao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).