From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41Qft03n8XzDqx6 for ; Wed, 11 Jul 2018 23:24:08 +1000 (AEST) In-Reply-To: <20180611202904.GA25538@jordon-HP-15-Notebook-PC> To: Souptick Joarder , willy@infradead.org, fbarrat@linux.vnet.ibm.com, andrew.donnellan@au1.ibm.com, arnd@arndb.de, gregkh@linuxfoundation.org From: Michael Ellerman Cc: brajeswar.linux@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, sabyasachi.linux@gmail.com Subject: Re: misc: ocxl: Change return type for fault handler Message-Id: <41Qft01FR3zB4MS@ozlabs.org> Date: Wed, 11 Jul 2018 23:24:07 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2018-06-11 at 20:29:04 UTC, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. > > Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") > > There is an existing bug when vm_insert_pfn() can return > ENOMEM which was ignored and VM_FAULT_NOPAGE returned as > default. The new inline vmf_insert_pfn() has removed > this inefficiency by returning correct vm_fault_ type. > > Signed-off-by: Souptick Joarder > Acked-by: Andrew Donnellan > Acked-by: Frederic Barrat Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a545cf032d11437ed86e62f00d4991 cheers