From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41Z4h86R1HzDrvG for ; Tue, 24 Jul 2018 01:11:20 +1000 (AEST) In-Reply-To: <20180717042430.15395-1-david@gibson.dropbear.id.au> To: David Gibson , aneesh.kumar@linux.vnet.ibm.com, paulus@samba.org From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, David Gibson Subject: Re: powerpc/hugetlbpage: Rmove unhelpful HUGEPD_*_SHIFT macros Message-Id: <41Z4h828kfz9s4s@ozlabs.org> Date: Tue, 24 Jul 2018 01:11:19 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2018-07-17 at 04:24:30 UTC, David Gibson wrote: > The HUGEPD_*_SHIFT macros are always defined to be PGDIR_SHIFT and > PUD_SHIFT, and have to have those values to work properly. They once used > to have different values, but that was really only because they were used > to mean different things in different contexts. > > 6fa50483 "powerpc/mm/hugetlb: initialize the pagetable cache correctly for > hugetlb" removed that double meaning, but left the now useless constants. > > Signed-off-by: David Gibson Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/fdf743c5c51d5b45db4dada3910954 cheers