From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41gMDG4LnTzF10S for ; Wed, 1 Aug 2018 15:23:58 +1000 (AEST) In-Reply-To: <720e9899186bed184fb9b5cce070e2dc519f9665.1530519301.git.fthain@telegraphics.com.au> To: Finn Thain , Benjamin Herrenschmidt From: Michael Ellerman Cc: Michael Schmitz , linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [v4,01/11] macintosh/via-pmu: Fix section mismatch warning Message-Id: <41gMDG3RdFz9s3q@ozlabs.org> Date: Wed, 1 Aug 2018 15:23:58 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2018-07-02 at 08:21:18 UTC, Finn Thain wrote: > The pmu_init() function has the __init qualifier, but the ops struct > that holds a pointer to it does not. This causes a build warning. > The driver works fine because the pointer is only dereferenced early. > > The function is so small that there's negligible benefit from using > the __init qualifier. Remove it to fix the warning, consistent with > the other ADB drivers. > > Tested-by: Stan Johnson > Signed-off-by: Finn Thain > Reviewed-by: Geert Uytterhoeven Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/73f4447d43484224d7abfba0d9468d cheers