From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Haren Myneni <haren@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, herbert@gondor.apana.org.au,
stewart@linux.ibm.com, linux-crypto@vger.kernel.org
Subject: Re: [V3, 2/2] crypto/nx: Initialize 842 high and normal RxFIFO control registers
Date: Thu, 9 Aug 2018 00:25:29 +1000 (AEST) [thread overview]
Message-ID: <41ltvw207Bz9s0n@ozlabs.org> (raw)
In-Reply-To: <1528875160.14408.6.camel@hbabu-laptop>
On Wed, 2018-06-13 at 07:32:40 UTC, Haren Myneni wrote:
> NX increments readOffset by FIFO size in receive FIFO control register
> when CRB is read. But the index in RxFIFO has to match with the
> corresponding entry in FIFO maintained by VAS in kernel. Otherwise NX
> may be processing incorrect CRBs and can cause CRB timeout.
>
> VAS FIFO offset is 0 when the receive window is opened during
> initialization. When the module is reloaded or in kexec boot, readOffset
> in FIFO control register may not match with VAS entry. This patch adds
> nx_coproc_init OPAL call to reset readOffset and queued entries in FIFO
> control register for both high and normal FIFOs.
>
> Signed-off-by: Haren Myneni <haren@us.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/656ecc16e8fc2ab44b3d70e3fcc197
cheers
prev parent reply other threads:[~2018-08-08 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 7:32 [PATCH V3 2/2] crypto/nx: Initialize 842 high and normal RxFIFO control registers Haren Myneni
2018-08-08 14:25 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ltvw207Bz9s0n@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=haren@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stewart@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).