From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@ozlabs.org>
Cc: Laurent Dufour <ldufour@linux.vnet.ibm.com>,
Michal Suchanek <msuchanek@suse.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [v6, 1/8] powerpc/pseries: Avoid using the size greater than RTAS_ERROR_LOG_MAX.
Date: Thu, 9 Aug 2018 00:25:32 +1000 (AEST) [thread overview]
Message-ID: <41ltvx6gM6z9s3Z@ozlabs.org> (raw)
In-Reply-To: <153072701775.29016.13501175476729182702.stgit@jupiter.in.ibm.com>
On Wed, 2018-07-04 at 17:57:02 UTC, Mahesh J Salgaonkar wrote:
> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>
> The global mce data buffer that used to copy rtas error log is of 2048
> (RTAS_ERROR_LOG_MAX) bytes in size. Before the copy we read
> extended_log_length from rtas error log header, then use max of
> extended_log_length and RTAS_ERROR_LOG_MAX as a size of data to be copied.
> Ideally the platform (phyp) will never send extended error log with
> size > 2048. But if that happens, then we have a risk of buffer overrun
> and corruption. Fix this by using min_t instead.
>
> Fixes: d368514c3097 ("powerpc: Fix corruption when grabbing FWNMI data")
> Reported-by: Michal Suchanek <msuchanek@suse.com>
> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/74e96bf44f430cf7a01de19ba6cf49
cheers
next prev parent reply other threads:[~2018-08-08 14:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 17:56 [PATCH v6 0/8] powerpc/pseries: Machine check handler improvements Mahesh J Salgaonkar
2018-07-04 17:57 ` [PATCH v6 1/8] powerpc/pseries: Avoid using the size greater than RTAS_ERROR_LOG_MAX Mahesh J Salgaonkar
2018-08-08 14:25 ` Michael Ellerman [this message]
2018-07-04 17:57 ` [PATCH v6 2/8] powerpc/pseries: Defer the logging of rtas error to irq work queue Mahesh J Salgaonkar
2018-08-08 14:25 ` [v6, " Michael Ellerman
2018-07-04 17:57 ` [PATCH v6 3/8] powerpc/pseries: Fix endainness while restoring of r3 in MCE handler Mahesh J Salgaonkar
2018-07-04 17:57 ` [PATCH v6 4/8] powerpc/pseries: Define MCE error event section Mahesh J Salgaonkar
2018-07-04 17:58 ` [PATCH v6 5/8] powerpc/pseries: flush SLB contents on SLB MCE errors Mahesh J Salgaonkar
2018-07-10 16:53 ` Michal Suchánek
2018-08-01 5:58 ` Nicholas Piggin
2018-08-02 5:00 ` Mahesh Jagannath Salgaonkar
2018-08-02 7:50 ` Nicholas Piggin
2018-07-04 17:58 ` [PATCH v6 6/8] powerpc/pseries: Display machine check error details Mahesh J Salgaonkar
2018-07-04 17:59 ` [PATCH v6 7/8] powerpc/pseries: Dump the SLB contents on SLB MCE errors Mahesh J Salgaonkar
2018-07-04 18:00 ` [PATCH v6 8/8] powernv/pseries: consolidate code for mce early handling Mahesh J Salgaonkar
2018-07-06 9:40 ` Nicholas Piggin
2018-07-09 16:02 ` Michal Suchánek
2018-08-01 6:10 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ltvx6gM6z9s3Z@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=msuchanek@suse.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).