From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Mathieu Malaterre <malat@debian.org>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Cc: Mathieu Malaterre <malat@debian.org>,
linuxppc-dev@lists.ozlabs.org,
Christophe Lombard <clombard@linux.vnet.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Subject: Re: cxl: remove a dead branch
Date: Mon, 13 Aug 2018 21:22:55 +1000 (AEST) [thread overview]
Message-ID: <41ptcv2xyYz9sC7@ozlabs.org> (raw)
In-Reply-To: <20180322210528.22017-1-malat@debian.org>
On Thu, 2018-03-22 at 21:05:28 UTC, Mathieu Malaterre wrote:
> In commit 14baf4d9c739 ("cxl: Add guest-specific code") the following code
> was added:
>
> if (afu->crs_len < 0) {
> dev_err(&afu->dev, "Unexpected configuration record size value\n");
> return -EINVAL;
> }
>
> However the variable `crs_len` is of type u64 and cannot be compared < 0.
> Remove the dead code section. Fix the following warning treated as error
> with W=1:
>
> ../drivers/misc/cxl/guest.c:919:19: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e4ecafb14fd9cd77d8f4320af1922e
cheers
next prev parent reply other threads:[~2018-08-13 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 21:05 [PATCH] cxl: remove a dead branch Mathieu Malaterre
2018-03-27 16:53 ` Frederic Barrat
2018-08-13 11:22 ` Michael Ellerman [this message]
2018-08-13 11:25 ` Mathieu Malaterre
2018-08-14 4:13 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ptcv2xyYz9sC7@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=clombard@linux.vnet.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=malat@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).