From: Andre' Draszik <andid@gmx.net>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH][PPC32] PPC4xx ocp ide rewrite/cleanup
Date: Sat, 19 Feb 2005 10:28:37 +0100 [thread overview]
Message-ID: <421706C5.50200@gmx.net> (raw)
In-Reply-To: <20050217103527.A5230@cox.net>
Hi,
Matt Porter wrote:
> Ok, this one looks good save a few minor things that need done:
i will address these as soon as i have time again, i.e. on wednesday.
> 1) Rename from ibm_ocp_ide.[c|h] to ibm_stb_ide.[c|h] We want
> rid of "ocp" in the file names since eventually 4xx will
> convert to platform devices.
is diff -N appropriate for that and convenient for you? as said, i'm using
the rsync mirror only, no bitkeeper.
> 2) Remove the #if 0'ed code...if it's not used it doesn't belong
> in there.
ok.
> 3) Run Lindent on the driver.
ok.
Shall I send the new patch against the one I already sent or against the
unpatched tree?
> What systems have you tested on?
On two different custom built boards both based on the redwood5 reference
design.
a.
prev parent reply other threads:[~2005-02-19 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-07 4:24 [PATCH][PPC32] PPC4xx ocp ide rewrite/cleanup Andre' Draszik
2005-02-16 23:14 ` Matt Porter
2005-02-17 1:19 ` Andre' Draszik
2005-02-17 1:43 ` Matt Porter
2005-02-17 17:35 ` Matt Porter
2005-02-19 9:28 ` Andre' Draszik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421706C5.50200@gmx.net \
--to=andid@gmx.net \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).