* PATCH: add ppc PVR register values for 7447A and 7457 CPUs
@ 2005-02-23 20:48 James Chapman
2005-02-23 22:25 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: James Chapman @ 2005-02-23 20:48 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Signed-off-by: James Chapman <jchapman@katalix.com>
Trivial patch to add 7447A and 7457 CPU defs.
[-- Attachment #2: ppc_cpu_regs.patch --]
[-- Type: text/plain, Size: 737 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/02/23 16:17:49+00:00 jchapman@katalix.com
# Add ppc PVR definitions for 7447A and 7457 CPUs.
#
# include/asm-ppc/reg.h
# 2005/02/23 16:17:40+00:00 jchapman@katalix.com +2 -0
# Add ppc PVR definitions for 7447A and 7457 CPUs.
#
diff -Nru a/include/asm-ppc/reg.h b/include/asm-ppc/reg.h
--- a/include/asm-ppc/reg.h 2005-02-23 16:18:45 +00:00
+++ b/include/asm-ppc/reg.h 2005-02-23 16:18:45 +00:00
@@ -471,7 +471,9 @@
#define PVR_750P PVR_740P
#define PVR_7400 0x000C0000
#define PVR_7410 0x800C0000
+#define PVR_7447A 0x80030000
#define PVR_7450 0x80000000
+#define PVR_7457 0x80020000
#define PVR_8540 0x80200000
#define PVR_8560 0x80200000
/*
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs
2005-02-23 20:48 PATCH: add ppc PVR register values for 7447A and 7457 CPUs James Chapman
@ 2005-02-23 22:25 ` Tom Rini
2005-02-23 22:52 ` Kumar Gala
2005-02-24 9:01 ` James Chapman
0 siblings, 2 replies; 7+ messages in thread
From: Tom Rini @ 2005-02-23 22:25 UTC (permalink / raw)
To: James Chapman; +Cc: linuxppc-dev
On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
> Signed-off-by: James Chapman <jchapman@katalix.com>
>
> Trivial patch to add 7447A and 7457 CPU defs.
Why? Most of the PVR definitions here can be removed (*muttering about
85xx ones being added).
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs
2005-02-23 22:25 ` Tom Rini
@ 2005-02-23 22:52 ` Kumar Gala
2005-02-24 5:16 ` Kumar Gala
2005-02-24 9:01 ` James Chapman
1 sibling, 1 reply; 7+ messages in thread
From: Kumar Gala @ 2005-02-23 22:52 UTC (permalink / raw)
To: Tom Rini; +Cc: linuxppc-dev
On Feb 23, 2005, at 4:25 PM, Tom Rini wrote:
> On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
> > Signed-off-by: James Chapman <jchapman@katalix.com>
> >
> > Trivial patch to add 7447A and 7457 CPU defs.
>
> Why?=A0 Most of the PVR definitions here can be removed (*muttering =
about
> 85xx ones being added).
Yeah, yeah, will work on removing them.
- kumar
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs
2005-02-23 22:52 ` Kumar Gala
@ 2005-02-24 5:16 ` Kumar Gala
0 siblings, 0 replies; 7+ messages in thread
From: Kumar Gala @ 2005-02-24 5:16 UTC (permalink / raw)
To: Tom Rini; +Cc: linuxppc-dev list
Tom,
Here are the only usages of PVR_<CPU> that are in arch/ppc:
boot/simple/misc-ev64260.S: cmplwi r25,(PVR_7450 >> 16)
platforms/ev64260.c: if (pvr !=3D PVR_VER(PVR_7450)) {
platforms/4xx/ebony.c: case PVR_REV(PVR_440GP_RB):
platforms/4xx/ebony.c: case PVR_REV(PVR_440GP_RC1):
syslib/ibm440gx_common.c: if (pvr =3D=3D PVR_440GX_RA || pvr =3D=3D=20=
PVR_440GX_RB ||
syslib/ibm440gx_common.c: (pvr =3D=3D PVR_440GX_RC && p->cpu >=20=
667000000))
What do you think should we just get ride of all the other cases that=20
are not actually used and leave these in asm/regs.h or should we move=20
them as follows:
PVR_7450 -> into platforms/ev64260.h
PVR_440GP* -> into platforms/4xx/ebony.c (or include/asm/ibm4xx.h)
PVR_440GX* -> into syslib/ibm440gx_common.h
- kumar
On Feb 23, 2005, at 4:52 PM, Kumar Gala wrote:
>
>
> On Feb 23, 2005, at 4:25 PM, Tom Rini wrote:
>
> > On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
> >=A0 > Signed-off-by: James Chapman <jchapman@katalix.com>
> > >
> > > Trivial patch to add 7447A and 7457 CPU defs.
> >
> > Why?=A0 Most of the PVR definitions here can be removed (*muttering=20=
> about
> >=A0 85xx ones being added).
>
> Yeah, yeah, will work on removing them.
>
> - kumar
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs
2005-02-23 22:25 ` Tom Rini
2005-02-23 22:52 ` Kumar Gala
@ 2005-02-24 9:01 ` James Chapman
2005-02-24 14:18 ` Tom Rini
1 sibling, 1 reply; 7+ messages in thread
From: James Chapman @ 2005-02-24 9:01 UTC (permalink / raw)
To: Tom Rini; +Cc: linuxppc-dev
Tom Rini wrote:
> On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
>
>>Signed-off-by: James Chapman <jchapman@katalix.com>
>>
>>Trivial patch to add 7447A and 7457 CPU defs.
>
>
> Why? Most of the PVR definitions here can be removed (*muttering about
> 85xx ones being added).
>
I'm in the process of submitting a patch for a new board (Radstone
PPC7D). Since other boards test CPU type using definitions in this file,
I was trying to be consistent.
If the community don't think those definitions are useful, I'll just
move the ones I need into my board support stuff.
--
James Chapman
PGP key : http://www.katalix.com/~jchapman/pgpkey.txt
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs
2005-02-24 9:01 ` James Chapman
@ 2005-02-24 14:18 ` Tom Rini
2005-02-24 15:50 ` James Chapman
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2005-02-24 14:18 UTC (permalink / raw)
To: James Chapman; +Cc: linuxppc-dev
On Thu, Feb 24, 2005 at 09:01:50AM +0000, James Chapman wrote:
> Tom Rini wrote:
>
> >On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
> >
> >>Signed-off-by: James Chapman <jchapman@katalix.com>
> >>
> >>Trivial patch to add 7447A and 7457 CPU defs.
> >
> >
> >Why? Most of the PVR definitions here can be removed (*muttering about
> >85xx ones being added).
> >
>
> I'm in the process of submitting a patch for a new board (Radstone
> PPC7D). Since other boards test CPU type using definitions in this file,
> I was trying to be consistent.
>
> If the community don't think those definitions are useful, I'll just
> move the ones I need into my board support stuff.
Is there something you can't get from cur_cpu_spec[0] ? That's why all
of the PVR definitions _should_ be unneeded now.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-02-24 15:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-23 20:48 PATCH: add ppc PVR register values for 7447A and 7457 CPUs James Chapman
2005-02-23 22:25 ` Tom Rini
2005-02-23 22:52 ` Kumar Gala
2005-02-24 5:16 ` Kumar Gala
2005-02-24 9:01 ` James Chapman
2005-02-24 14:18 ` Tom Rini
2005-02-24 15:50 ` James Chapman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).