From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ptb-relay02.plus.net (ptb-relay02.plus.net [212.159.14.213]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 7FB1367A87 for ; Wed, 16 Mar 2005 20:46:55 +1100 (EST) Message-ID: <42380075.1070206@katalix.com> Date: Wed, 16 Mar 2005 09:46:29 +0000 From: James Chapman MIME-Version: 1.0 To: Andrew Morton References: <42376A46.2090605@mvista.com> <20050315225050.4a236b3e.akpm@osdl.org> In-Reply-To: <20050315225050.4a236b3e.akpm@osdl.org> Content-Type: text/plain; charset=us-ascii; format=flowed Cc: linuxppc-embedded@ozlabs.org Subject: Re: [PATCH 2.6.11] ppc32: update Radstone ppc7d platform List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Andrew Morton wrote: > "Mark A. Greer" wrote: > >> +ppc7d_fixup_i2c_pdata(struct platform_device *pdev) >> +{ >> + struct mv64xxx_i2c_pdata *pdata; >> + int i; >> + >> + pdata = pdev->dev.platform_data; >> + if (pdata == NULL) { >> + pdata = kmalloc(GFP_KERNEL, sizeof(*pdata)); > > > I'll switch those kmalloc args around for you. Wow, I'm surprised it ever worked! Thanks!