* [PATCH] compilation failure due to confliction of time_offset
@ 2005-03-12 16:45 Takeharu KATO
2005-03-16 22:22 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Takeharu KATO @ 2005-03-12 16:45 UTC (permalink / raw)
To: linuxppc-embedded, galak, mporter, ebs
Hi all:
I send carbon copy of the mail to maintainers of Embedded PowerPC,
because I can not figure out who is responsible for arch/ppc/kernel/time.c.
I found a trivial bug made compilation fail.
I show error log as follows:
-- error log
arch/ppc/kernel/time.c:92: error: static declaration of 'time_offset'
follows non-static declaration
include/linux/timex.h:236: error: previous declaration of 'time_offset'
was heremake[1]: *** [arch/ppc/kernel/time.o] Error 1
make: *** [arch/ppc/kernel] Error 2
--
Please apply following patch if this is a correct fix.
Regards,
--
Takeharu KATO
Signed-off-by: Takeharu KATO <takeharu1219@ybb.ne.jp>
--- linux-2.6.11.maybe/arch/ppc/kernel/time.c 2005-03-05
23:58:20.000000000 +0900
+++ linux-2.6.11/arch/ppc/kernel/time.c 2005-03-13 00:46:49.000000000 +0900
@@ -89,7 +89,6 @@ unsigned long tb_to_ns_scale;
extern unsigned long wall_jiffies;
-static long time_offset;
DEFINE_SPINLOCK(rtc_lock);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] compilation failure due to confliction of time_offset
2005-03-12 16:45 [PATCH] compilation failure due to confliction of time_offset Takeharu KATO
@ 2005-03-16 22:22 ` Tom Rini
2005-03-17 0:36 ` Takeharu KATO
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2005-03-16 22:22 UTC (permalink / raw)
To: Takeharu KATO; +Cc: galak, linuxppc-embedded
On Sun, Mar 13, 2005 at 01:45:28AM +0900, Takeharu KATO wrote:
> Hi all:
>
> I send carbon copy of the mail to maintainers of Embedded PowerPC,
> because I can not figure out who is responsible for arch/ppc/kernel/time.c.
>
> I found a trivial bug made compilation fail.
> I show error log as follows:
>
> -- error log
> arch/ppc/kernel/time.c:92: error: static declaration of 'time_offset'
> follows non-static declaration
> include/linux/timex.h:236: error: previous declaration of 'time_offset'
> was heremake[1]: *** [arch/ppc/kernel/time.o] Error 1
> make: *** [arch/ppc/kernel] Error 2
Are you certain that the 'time_offset' referenced in <linux/timex.h> is
what wants to be used in arch/ppc/kernel/time.c ? Thanks.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] compilation failure due to confliction of time_offset
2005-03-16 22:22 ` Tom Rini
@ 2005-03-17 0:36 ` Takeharu KATO
0 siblings, 0 replies; 3+ messages in thread
From: Takeharu KATO @ 2005-03-17 0:36 UTC (permalink / raw)
To: Tom Rini; +Cc: galak, linuxppc-embedded
Tom:
Sorry, I did misunderstand about it.
I'll fix this if nobody is working on this problem.
Tom Rini wrote:
>
>
> Are you certain that the 'time_offset' referenced in <linux/timex.h> is
> what wants to be used in arch/ppc/kernel/time.c ? Thanks.
>
--
Takeharu KATO
Fujitsu Limited
Email:kato.takeharu at jp.fujitsu.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-17 0:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-12 16:45 [PATCH] compilation failure due to confliction of time_offset Takeharu KATO
2005-03-16 22:22 ` Tom Rini
2005-03-17 0:36 ` Takeharu KATO
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).