From: Pantelis Antoniou <panto@intracom.gr>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: Tom Rini <trini@kernel.crashing.org>,
linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH 03/04] Freescale Ethernet combined driver
Date: Tue, 10 May 2005 14:17:49 +0300 [thread overview]
Message-ID: <4280985D.80108@intracom.gr> (raw)
In-Reply-To: <20050509133808.A16776@cox.net>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
Matt Porter wrote:
> On Mon, May 09, 2005 at 02:45:03PM +0300, Pantelis Antoniou wrote:
>
>>Hi
>>
>>The following patch is a combined FCC/FEC ethernet driver
>>for the Freescale line of PowerQUICCs.
>>
>>FECs on 8xx and FCCs on 82xx are supported.
>>
>>This part of the patch contains the mac drivers
>>for FEC & FCC.
>
>
> As mentioned on IRC, this needs to be scrubbed of all iopa() usage
> in favor of standard DMA API calls.
>
> -Matt
>
>
This patch replace iopa use with virt_to_phys.
Regards
Pantelis
[-- Attachment #2: fs_enet-iopa-kill.patch --]
[-- Type: text/x-patch, Size: 1311 bytes --]
Index: linux-2.6.11.7-fs_enet/drivers/net/fs_enet/mac-fcc.c
===================================================================
--- linux-2.6.11.7-fs_enet.orig/drivers/net/fs_enet/mac-fcc.c
+++ linux-2.6.11.7-fs_enet/drivers/net/fs_enet/mac-fcc.c
@@ -226,8 +226,8 @@ static void restart(struct net_device *d
__fcc_out8((char *)ep + i, 0);
/* point to bds */
- W32(ep, fen_genfcc.fcc_rbase, iopa((__u32)fep->rx_bd_base));
- W32(ep, fen_genfcc.fcc_tbase, iopa((__u32)fep->tx_bd_base));
+ W32(ep, fen_genfcc.fcc_rbase, virt_to_phys(fep->rx_bd_base));
+ W32(ep, fen_genfcc.fcc_tbase, virt_to_phys(fep->tx_bd_base));
/* Set maximum bytes per receive buffer.
* It must be a multiple of 32.
Index: linux-2.6.11.7-fs_enet/drivers/net/fs_enet/mac-fec.c
===================================================================
--- linux-2.6.11.7-fs_enet.orig/drivers/net/fs_enet/mac-fec.c
+++ linux-2.6.11.7-fs_enet/drivers/net/fs_enet/mac-fec.c
@@ -306,8 +306,8 @@ static void restart(struct net_device *d
/*
* Set receive and transmit descriptor base.
*/
- FW(fecp, r_des_start, iopa((__u32)fep->rx_bd_base));
- FW(fecp, x_des_start, iopa((__u32)fep->tx_bd_base));
+ FW(fecp, r_des_start, virt_to_phys(fep->rx_bd_base));
+ FW(fecp, x_des_start, virt_to_phys(fep->tx_bd_base));
fs_init_bds(dev);
next prev parent reply other threads:[~2005-05-10 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-09 11:45 [PATCH 03/04] Freescale Ethernet combined driver Pantelis Antoniou
2005-05-09 20:38 ` Matt Porter
2005-05-10 11:17 ` Pantelis Antoniou [this message]
2005-05-10 12:13 ` Dan Malek
2005-05-10 12:15 ` Pantelis Antoniou
2005-05-10 13:27 ` Matt Porter
2005-05-10 13:14 ` Pantelis Antoniou
2005-05-10 13:47 ` Matt Porter
2005-05-10 13:36 ` Pantelis Antoniou
2005-05-12 9:37 ` Pantelis Antoniou
2005-05-13 8:51 ` Pantelis Antoniou
2005-05-10 18:14 ` Dan Malek
-- strict thread matches above, loose matches on Subject: below --
2005-05-10 14:53 Rune Torgersen
2005-05-10 18:24 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4280985D.80108@intracom.gr \
--to=panto@intracom.gr \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mporter@kernel.crashing.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).