From: Randy Vinson <rvinson@mvista.com>
To: Kumar Gala <kumar.gala@freescale.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: [PATCH][PPC32] MPC834x BCSR_SIZE too small for use in a BAT
Date: Wed, 25 May 2005 17:01:12 -0700 [thread overview]
Message-ID: <429511C8.1010205@mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
Greetings,
The value of BCSR_SIZE (32K) in arch/ppc/platforms/83xx/mpc834x_sys.h
is too small for a BAT (min 128K). The size is used in an
io_block_mapping call to map the Board Control and Status Registers.
Since there are no current dependencies on the result of the
io_block_mapping call, it was removed as a solution to the problem
rather than increasing the value of BCSR_SIZE. If access to the BCSR
block is needed, it can easily be mapped via ioremap at the point of use.
Randy Vinson
[-- Attachment #2: bcsr.patch --]
[-- Type: text/plain, Size: 1858 bytes --]
MPC834x BCSR_SIZE too small for use in a BAT.
The call to io_block_mapping was creating an invalid BAT entry because
the value of BCSR_SIZE (32K) is too small to be used in a BAT (128K min).
This change removes the io_block_mapping call since these registers can
easily be mapped using ioremap at the point of use.
Signed-off-by: Randy Vinson <rvinson@mvista.com>
---
commit 269bcdbf0a9f000400052b2da38348733dbfe88f
tree d10f5c31c29228a00a1a7551e3e825b439bfc741
parent 1b981021e88c8c28dc6a22cb1a327d8dc9296473
author Randy Vinson <rvinson@linuxbox.(none)> Wed, 25 May 2005 16:14:40 -0700
committer Randy Vinson <rvinson@linuxbox.(none)> Wed, 25 May 2005 16:14:40 -0700
arch/ppc/platforms/83xx/mpc834x_sys.c | 1 -
arch/ppc/platforms/83xx/mpc834x_sys.h | 1 -
2 files changed, 2 deletions(-)
Index: arch/ppc/platforms/83xx/mpc834x_sys.c
===================================================================
--- 5eeefa658d7f9c13cd352994805ac3ead628b7e9/arch/ppc/platforms/83xx/mpc834x_sys.c (mode:100644)
+++ d10f5c31c29228a00a1a7551e3e825b439bfc741/arch/ppc/platforms/83xx/mpc834x_sys.c (mode:100644)
@@ -127,7 +127,6 @@
{
/* we steal the lowest ioremap addr for virt space */
io_block_mapping(VIRT_IMMRBAR, immrbar, 1024*1024, _PAGE_IO);
- io_block_mapping(BCSR_VIRT_ADDR, BCSR_PHYS_ADDR, BCSR_SIZE, _PAGE_IO);
}
int
Index: arch/ppc/platforms/83xx/mpc834x_sys.h
===================================================================
--- 5eeefa658d7f9c13cd352994805ac3ead628b7e9/arch/ppc/platforms/83xx/mpc834x_sys.h (mode:100644)
+++ d10f5c31c29228a00a1a7551e3e825b439bfc741/arch/ppc/platforms/83xx/mpc834x_sys.h (mode:100644)
@@ -26,7 +26,6 @@
#define VIRT_IMMRBAR ((uint)0xfe000000)
#define BCSR_PHYS_ADDR ((uint)0xf8000000)
-#define BCSR_VIRT_ADDR ((uint)0xfe100000)
#define BCSR_SIZE ((uint)(32 * 1024))
#ifdef CONFIG_PCI
next reply other threads:[~2005-05-25 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 0:01 Randy Vinson [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-27 22:08 [PATCH] ppc32: MPC834x BCSR_SIZE too small for use in a BAT Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429511C8.1010205@mvista.com \
--to=rvinson@mvista.com \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).