From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5C8A2DDE1A for ; Sat, 8 Nov 2008 02:36:58 +1100 (EST) Message-Id: <42C08331-8747-4175-82B6-B19A07FA2872@kernel.crashing.org> From: Kumar Gala To: Martyn Welch In-Reply-To: <20081107151614.534d4607.martyn.welch@gefanuc.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v929.2) Subject: Re: [PATCH] powerpc: Watchdog timer support for GE Fanuc SBC610 Date: Fri, 7 Nov 2008 09:36:51 -0600 References: <20081107143818.9129.47899.stgit@ubuntu8041.localdomain> <6A6D7DCB-067A-4891-B922-536765D6E6FB@kernel.crashing.org> <20081107151614.534d4607.martyn.welch@gefanuc.com> Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Nov 7, 2008, at 9:16 AM, Martyn Welch wrote: > On Fri, 7 Nov 2008 08:44:45 -0600 > Kumar Gala wrote: >> >> On Nov 7, 2008, at 8:38 AM, Martyn Welch wrote: >> >>> Support for the SBC610 VPX Single Baord Computer from GE Fanuc >>> (PowerPC >>> MPC8641D). >>> >>> This patch adds support for the watchdog timer in the devices main >>> FPGA. >>> There are two identical watchdog timers at different offsets in the >>> main >>> FPGA, this driver is capable of supporting one of them. The watchdog >>> timers >>> are also capable of generating interrupts at a user-configurable >>> threshold, >>> though support for this operation is currently not supported by the >>> driver. >>> >>> Signed-off-by: Martyn Welch >>> --- >>> >>> arch/powerpc/boot/dts/gef_sbc610.dts | 19 + >>> arch/powerpc/configs/86xx/gef_sbc610_defconfig | 1 >>> drivers/watchdog/Kconfig | 6 >>> drivers/watchdog/Makefile | 1 >>> drivers/watchdog/gef_wdt.c | 333 +++++++++++++ >>> ++ >>> +++++++++ >>> 5 files changed, 360 insertions(+), 0 deletions(-) >> >> Can you break this into two patches. One for the driver and one for >> the arch/powerpc stuff. the driver should go via the watchdog >> maintainer (and CC that list). >> > > Yeah - sorry, didn't think about that. > > Thinking about it, the driver is specific to GEF Fanuc boards, > should this be > going into drivers/watchdog/ or would it be better for me to move it > to > arch/powerpc? It should still be in drivers/watchdog. - k