From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Breno Leitao <leitao@debian.org>, linuxppc-dev@lists.ozlabs.org
Cc: Breno Leitao <leitao@debian.org>,
Alistair Popple <alistair@popple.id.au>
Subject: Re: powerpc/iommu: avoid derefence before pointer check
Date: Thu, 20 Sep 2018 14:20:59 +1000 (AEST) [thread overview]
Message-ID: <42G3SW2tMMz9sCm@ozlabs.org> (raw)
In-Reply-To: <1534877088-22303-1-git-send-email-leitao@debian.org>
On Tue, 2018-08-21 at 18:44:48 UTC, Breno Leitao wrote:
> The tbl pointer is being derefenced by IOMMU_PAGE_SIZE prior the check if
> it is not NULL.
>
> Just moving the dereference code to after the check, where there will be
> guarantee that 'tbl' will not be NULL.
>
> CC: Alistair Popple <alistair@popple.id.au>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/984ecdd68de0fa1f63ce205d6c19ef
cheers
prev parent reply other threads:[~2018-09-20 4:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 18:44 [PATCH] powerpc/iommu: avoid derefence before pointer check Breno Leitao
2018-09-20 4:20 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42G3SW2tMMz9sCm@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=alistair@popple.id.au \
--cc=leitao@debian.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).