From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Breno Leitao <leitao@debian.org>, linuxppc-dev@lists.ozlabs.org
Cc: Breno Leitao <leitao@debian.org>, clg@kaod.org
Subject: Re: [v2] powerpc/xive: Avoid unitialized variable
Date: Thu, 20 Sep 2018 14:20:59 +1000 (AEST) [thread overview]
Message-ID: <42G3SW5cPRz9sCw@ozlabs.org> (raw)
In-Reply-To: <1535066799-8493-1-git-send-email-leitao@debian.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Thu, 2018-08-23 at 23:26:39 UTC, Breno Leitao wrote:
> From: Breno Leitao <breno.leitao@gmail.com>
>
> Function xive_native_get_ipi() might uses chip_id without it being
> initialized.
>
> This gives the following error on 'smatch' tool:
>
> error: uninitialized symbol 'chip_id'
>
> The suggestion is using xc->chip_id instead of consulting the OF for chip id,
> which is safe since xive_prepare_cpu() should have initialized ->chip_id by
> the time xive_native_get_ipi() is called.
>
> CC: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/8ac9e5bfd8cf41ef106ac97267117e
cheers
prev parent reply other threads:[~2018-09-20 4:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 18:46 [PATCH] powerpc/xive: Initialize symbol before usage Breno Leitao
2018-08-23 3:24 ` Michael Ellerman
2018-08-23 5:26 ` Cédric Le Goater
2018-08-23 12:25 ` Michael Ellerman
2018-08-23 23:26 ` [PATCH v2] powerpc/xive: Avoid unitialized variable Breno Leitao
2018-08-24 6:58 ` Cédric Le Goater
2018-09-20 4:20 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42G3SW5cPRz9sCw@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=clg@kaod.org \
--cc=leitao@debian.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).