From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42G3Sh0d4XzF37B for ; Thu, 20 Sep 2018 14:21:08 +1000 (AEST) In-Reply-To: <153693396241.22873.15797641996113409474.stgit@hbathini.in.ibm.com> To: Hari Bathini From: Michael Ellerman Cc: linuxppc-dev , Dave Young , Mahesh J Salgaonkar , Petr Tesarik Subject: Re: powerpc/fadump: re-register firmware-assisted dump if already registered Message-Id: <42G3Sf1sg4z9sCS@ozlabs.org> Date: Thu, 20 Sep 2018 14:21:06 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2018-09-14 at 14:06:02 UTC, Hari Bathini wrote: > Firmware-Assisted Dump (FADump) needs to be registered again after any > memory hot add/remove operation to update the crash memory ranges. But > currently, the kernel returns '-EEXIST' if we try to register without > uregistering it first. This could expose the system to racing issues > while unregistering and registering FADump from userspace during udev > events. Spare the userspace of this and let it be taken care of in the > kernel space for a simpler interface. > > Since this change, running 'echo 1 > /sys/kernel/fadump_registered' > would result in re-regisering (unregistering and registering) FADump, > if it was already registered. > > Signed-off-by: Hari Bathini > Acked-by: Mahesh Salgaonkar Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/0823c68b054bca9dc321adea829af5 cheers