From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Breno Leitao <leitao@debian.org>, linuxppc-dev@lists.ozlabs.org
Cc: Breno Leitao <leitao@debian.org>, npiggin@gmail.com
Subject: Re: powerpc/powernv: Mark function as __noreturn
Date: Thu, 4 Oct 2018 16:14:40 +1000 (AEST) [thread overview]
Message-ID: <42QjKD5QDwz9sCr@ozlabs.org> (raw)
In-Reply-To: <1537885773-18564-1-git-send-email-leitao@debian.org>
On Tue, 2018-09-25 at 14:29:33 UTC, Breno Leitao wrote:
> There is a mismatch between function pnv_platform_error_reboot() definition
> and declaration regarding function modifiers. In the declaration part, it
> contains the function attribute __noreturn, while function definition
> itself lacks it.
>
> This was reported by sparse tool as an error:
>
> arch/powerpc/platforms/powernv/opal.c:538:6: error: symbol 'pnv_platform_error_reboot' redeclared with different type (originally declared at arch/powerpc/platforms/powernv/powernv.h:11) - different modifiers
>
> I checked and the function is already being considered as being 'noreturn'
> by the compiler, thus, I understand this patch does not change any code
> being generated.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/62dea077f56728979e40a741c8a094
cheers
prev parent reply other threads:[~2018-10-04 6:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 14:29 [PATCH] powerpc/powernv: Mark function as __noreturn Breno Leitao
2018-10-04 6:14 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42QjKD5QDwz9sCr@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=leitao@debian.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).