From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: jannh@google.com, muriloo@linux.ibm.com
Subject: Re: powerpc: Don't print kernel instructions in show_user_instructions()
Date: Sat, 6 Oct 2018 22:14:15 +1000 (AEST) [thread overview]
Message-ID: <42S5CC1Bmcz9s5b@ozlabs.org> (raw)
In-Reply-To: <20181005132123.6038-1-mpe@ellerman.id.au>
On Fri, 2018-10-05 at 13:21:23 UTC, Michael Ellerman wrote:
> Recently we implemented show_user_instructions() which dumps the code
> around the NIP when a user space process dies with an unhandled
> signal. This was modelled on the x86 code, and we even went so far as
> to implement the exact same bug, namely that if the user process
> crashed with its NIP pointing into the kernel we will dump kernel text
> to dmesg. eg:
>
> bad-bctr[2996]: segfault (11) at c000000000010000 nip c000000000010000 lr 12d0b0894 code 1
> bad-bctr[2996]: code: fbe10068 7cbe2b78 7c7f1b78 fb610048 38a10028 38810020 fb810050 7f8802a6
> bad-bctr[2996]: code: 3860001c f8010080 48242371 60000000 <7c7b1b79> 4082002c e8010080 eb610048
>
> This was discovered on x86 by Jann Horn and fixed in commit
> 342db04ae712 ("x86/dumpstack: Don't dump kernel memory based on usermode RIP").
>
> Fix it by checking the adjusted NIP value (pc) and number of
> instructions against USER_DS, and bail if we fail the check, eg:
>
> bad-bctr[2969]: segfault (11) at c000000000010000 nip c000000000010000 lr 107930894 code 1
> bad-bctr[2969]: Bad NIP, not dumping instructions.
>
> Fixes: 88b0fe175735 ("powerpc: Add show_user_instructions()")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Reviewed-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
Applied to powerpc fixes.
https://git.kernel.org/powerpc/c/a932ed3b718147c6537da290b7a91e
cheers
next prev parent reply other threads:[~2018-10-06 12:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 13:21 [PATCH] powerpc: Don't print kernel instructions in show_user_instructions() Michael Ellerman
2018-10-05 13:52 ` Christophe LEROY
2018-10-08 8:12 ` Michael Ellerman
2018-10-05 14:02 ` Jann Horn
2018-10-08 8:23 ` Michael Ellerman
2018-10-05 17:29 ` Murilo Opsfelder Araujo
2018-10-06 12:14 ` Michael Ellerman [this message]
2018-10-18 9:28 ` Christophe LEROY
2018-10-18 11:12 ` Jann Horn
2018-10-18 11:18 ` Christophe LEROY
2018-10-18 11:31 ` Jann Horn
2018-10-21 12:50 ` Michael Ellerman
2018-10-18 13:16 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42S5CC1Bmcz9s5b@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=jannh@google.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=muriloo@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).