From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Daniel Axtens <dja@axtens.net>, linuxppc-dev@lists.ozlabs.org
Cc: Daniel Axtens <dja@axtens.net>
Subject: Re: powerpc/nohash: fix undefined behaviour when testing page size support
Date: Thu, 11 Oct 2018 19:35:41 +1100 (AEDT) [thread overview]
Message-ID: <42W46j650vz9sjF@ozlabs.org> (raw)
In-Reply-To: <20181001062151.23831-1-dja@axtens.net>
On Mon, 2018-10-01 at 06:21:51 UTC, Daniel Axtens wrote:
> When enumerating page size definitions to check hardware support,
> we construct a constant which is (1U << (def->shift - 10)).
>
> However, the array of page size definitions is only initalised for
> various MMU_PAGE_* constants, so it contains a number of 0-initialised
> elements with def->shift == 0. This means we end up shifting by a
> very large number, which gives the following UBSan splat:
>
> ================================================================================
> UBSAN: Undefined behaviour in /home/dja/dev/linux/linux/arch/powerpc/mm/tlb_nohash.c:506:21
> shift exponent 4294967286 is too large for 32-bit type 'unsigned int'
> CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc3-00045-ga604f927b012-dirty #6
> Call Trace:
> [c00000000101bc20] [c000000000a13d54] .dump_stack+0xa8/0xec (unreliable)
> [c00000000101bcb0] [c0000000004f20a8] .ubsan_epilogue+0x18/0x64
> [c00000000101bd30] [c0000000004f2b10] .__ubsan_handle_shift_out_of_bounds+0x110/0x1a4
> [c00000000101be20] [c000000000d21760] .early_init_mmu+0x1b4/0x5a0
> [c00000000101bf10] [c000000000d1ba28] .early_setup+0x100/0x130
> [c00000000101bf90] [c000000000000528] start_here_multiplatform+0x68/0x80
> ================================================================================
>
> Fix this by first checking if the element exists (shift != 0) before
> constructing the constant.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f5e284803a7206d43e26f9ffcae5de
cheers
prev parent reply other threads:[~2018-10-11 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 6:21 [PATCH] powerpc/nohash: fix undefined behaviour when testing page size support Daniel Axtens
2018-10-11 8:35 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42W46j650vz9sjF@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=dja@axtens.net \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).