From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65519C28CF8 for ; Mon, 15 Oct 2018 04:12:14 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0673420652 for ; Mon, 15 Oct 2018 04:12:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0673420652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42YQ4r2n2gzF3B0 for ; Mon, 15 Oct 2018 15:12:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42YPqw1qD2zF13h for ; Mon, 15 Oct 2018 15:01:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 42YPqw0sy0z9s7W; Mon, 15 Oct 2018 15:00:59 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: f9bc28aedfb5bbd572d2d365f3095c1becd7209b In-Reply-To: <58b57fd67e045f7700b5a91b4f0f80089bca391e.1536715396.git.sbobroff@linux.ibm.com> To: Sam Bobroff , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [01/14] powerpc/eeh: Fix possible null deref in eeh_dump_dev_log() Message-Id: <42YPqw0sy0z9s7W@ozlabs.org> Date: Mon, 15 Oct 2018 15:00:59 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 2018-09-12 at 01:23:20 UTC, Sam Bobroff wrote: > If an error occurs during an unplug operation, it's possible for > eeh_dump_dev_log() to be called when edev->pdn is null, which > currently leads to dereferencing a null pointer. > > Handle this by skipping the error log for those devices. > > Signed-off-by: Sam Bobroff Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/f9bc28aedfb5bbd572d2d365f3095c cheers