From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Joel Stanley <joel@jms.id.au>, linuxppc-dev@lists.ozlabs.org
Cc: Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: powerpc: Disable -Wbuiltin-requires-header when setjmp is used
Date: Mon, 15 Oct 2018 15:01:00 +1100 (AEDT) [thread overview]
Message-ID: <42YPqw3Xpqz9sDQ@ozlabs.org> (raw)
In-Reply-To: <20180917074621.25066-1-joel@jms.id.au>
On Mon, 2018-09-17 at 07:46:21 UTC, Joel Stanley wrote:
> The powerpc kernel uses setjmp which causes a warning when building with
> clang:
>
> CC arch/powerpc/xmon/xmon.o
> In file included from arch/powerpc/xmon/xmon.c:51:
> ./arch/powerpc/include/asm/setjmp.h:15:13: error: declaration of
> built-in function 'setjmp' requires inclusion of the header <setjmp.h>
> [-Werror,-Wbuiltin-requires-header]
> extern long setjmp(long *);
> ^
> ./arch/powerpc/include/asm/setjmp.h:16:13: error: declaration of
> built-in function 'longjmp' requires inclusion of the header <setjmp.h>
> [-Werror,-Wbuiltin-requires-header]
> extern void longjmp(long *, long);
> ^
>
> This *is* the header and we're not using the built-in setjump but
> rather the one in arch/powerpc/kernel/misc.S. As the compiler warning
> does not make sense, it for the files where setjmp is used.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/aea447141c7e7824b81b49acd1bc78
cheers
prev parent reply other threads:[~2018-10-15 4:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 7:46 [PATCH] powerpc: Disable -Wbuiltin-requires-header when setjmp is used Joel Stanley
2018-09-17 17:13 ` Nick Desaulniers
2018-10-15 4:01 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42YPqw3Xpqz9sDQ@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).