From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: paulus@samba.org, anton@samba.org, kvm-ppc@vger.kernel.org
Subject: Re: powerpc/time: Fix clockevent_decrementer initalisation for PR KVM
Date: Mon, 22 Oct 2018 20:40:10 +1100 (AEDT) [thread overview]
Message-ID: <42ds233ZW4z9sDC@ozlabs.org> (raw)
In-Reply-To: <20181019042319.9457-1-mpe@ellerman.id.au>
On Fri, 2018-10-19 at 04:23:19 UTC, Michael Ellerman wrote:
> In the recent commit 8b78fdb045de ("powerpc/time: Use
> clockevents_register_device(), fixing an issue with large
> decrementer") we changed the way we initialise the decrementer
> clockevent(s).
>
> We no longer initialise the mult & shift values of
> decrementer_clockevent itself.
>
> This has the effect of breaking PR KVM, because it uses those values
> in kvmppc_emulate_dec(). The symptom is guest kernels spin forever
> mid-way through boot.
>
> For now fix it by assigning back to decrementer_clockevent the mult
> and shift values.
>
> Fixes: 8b78fdb045de ("powerpc/time: Use clockevents_register_device(), fixing an issue with large decrementer")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Acked-by: Anton Blanchard <anton@samba.org>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/b4d16ab58c41ff0125822464bdff07
cheers
prev parent reply other threads:[~2018-10-22 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 4:23 [PATCH] powerpc/time: Fix clockevent_decrementer initalisation for PR KVM Michael Ellerman
2018-10-20 6:59 ` Anton Blanchard
2018-10-22 9:40 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ds233ZW4z9sDC@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=anton@samba.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).