From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wPG5p32l7zDqby for ; Fri, 12 May 2017 13:43:10 +1000 (AEST) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v4C3cZWu065889 for ; Thu, 11 May 2017 23:42:58 -0400 Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) by mx0a-001b2d01.pphosted.com with ESMTP id 2acpt0dvu6-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 11 May 2017 23:42:57 -0400 Received: from localhost by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 May 2017 13:42:55 +1000 Received: from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v4C3gieb6488546 for ; Fri, 12 May 2017 13:42:52 +1000 Received: from d23av05.au.ibm.com (localhost [127.0.0.1]) by d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v4C3gJSc024180 for ; Fri, 12 May 2017 13:42:20 +1000 Subject: Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support To: Stewart Smith , Daniel Axtens , Anju T Sudhakar , mpe@ellerman.id.au References: <1493907596-11425-1-git-send-email-anju@linux.vnet.ibm.com> <1493907596-11425-6-git-send-email-anju@linux.vnet.ibm.com> <87shkfqvx6.fsf@possimpible.ozlabs.ibm.com> <0dfc6438-374c-3086-3847-832b5396e7f2@linux.vnet.ibm.com> <87a86iizre.fsf@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com, bsingharora@gmail.com, anton@samba.org, sukadev@linux.vnet.ibm.com, mikey@neuling.org, eranian@google.com, hemant@linux.vnet.ibm.com From: Madhavan Srinivasan Date: Fri, 12 May 2017 09:11:51 +0530 MIME-Version: 1.0 In-Reply-To: <87a86iizre.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Message-Id: <42effb3a-e747-97bf-2f78-255e94bbcf47@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday 12 May 2017 07:48 AM, Stewart Smith wrote: > Madhavan Srinivasan writes: >>> * in patch 9 should opal_imc_counters_init return something other >>> than OPAL_SUCCESS in the case on invalid arguments? Maybe >>> OPAL_PARAMETER? (I think you fix this in a later patch anyway?) >> So, init call will return OPAL_PARAMETER for the unsupported >> domains (core and nest are supported). And if the init operation >> fails for any reason, it would return OPAL_HARDWARE. And this is >> documented. > (I'll comment on the skiboot one too), but I think that if the class > exists but init is a no-op, then OPAL_IMC_COUNTERS_INIT should return > OPAL_SUCCESS and just do nothing. This future proofs everything, and the > API is that one *must* call _INIT before start. Hi stewart, Yes. mpe did mention this in his review. And i have made the same in the v11 of the opal patchset. Currently we return OPAL_SUCCESS from _INIT incase of type "Nest". Additionally i have also added a message to be printed but i guess we can get away with that. Maddy >