From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D21C6786F for ; Thu, 1 Nov 2018 12:59:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB4A520657 for ; Thu, 1 Nov 2018 12:59:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB4A520657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42m4zG5q2bzF3NS for ; Thu, 1 Nov 2018 23:59:22 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42m4hv1JSdzF3Ls for ; Thu, 1 Nov 2018 23:46:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 42m4ht5mGxzB4XN; Thu, 1 Nov 2018 23:46:54 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 1936f094e164cc13ebf17aba1d6b34e033e64188 In-Reply-To: <20181031171813.8970-1-naveen.n.rao@linux.vnet.ibm.com> To: "Naveen N. Rao" , Breno Leitao From: Michael Ellerman Subject: Re: selftests/powerpc: Fix compilation issue due to asm label Message-Id: <42m4ht5mGxzB4XN@ozlabs.org> Date: Thu, 1 Nov 2018 23:46:54 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 2018-10-31 at 17:18:13 UTC, "Naveen N. Rao" wrote: > We are using 'dscr_insn' as a label in inline asm to identify if a > SIGILL was generated by the mtspr instruction at that point. However, > with inline assembly, the compiler is still free to duplicate the asm > statement for optimization purposes, which results in the label being > defined twice with the error: > /tmp/ccerQCql.s:874: Error: symbol `dscr_insn' is already defined > > With different compiler versions, we may also see: > /tmp/ccJzLDlN.o:(.toc+0x0): undefined reference to `dscr_insn' > > Remove the use of the label in the inline assembly. Instead, just look > for the offending instruction in the signal handler. > > Reported-by: Breno Leitao > Signed-off-by: Naveen N. Rao > Tested-by: Breno Leitao Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1936f094e164cc13ebf17aba1d6b34 cheers