From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Scott Wood <oss@buserror.net>, Alexander Graf <agraf@suse.de>
Cc: Scott Wood <oss@buserror.net>,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org, Christian Zigotzky <chzigotzky@xenosoft.de>
Subject: Re: KVM: PPC: Move and undef TRACE_INCLUDE_PATH/FILE
Date: Thu, 8 Nov 2018 08:27:47 +1100 (AEDT) [thread overview]
Message-ID: <42qzz75NZpz9sCs@ozlabs.org> (raw)
In-Reply-To: <20181107014934.26428-1-oss@buserror.net>
On Wed, 2018-11-07 at 01:49:34 UTC, Scott Wood wrote:
> TRACE_INCLUDE_PATH and TRACE_INCLUDE_FILE are used by
> <trace/define_trace.h>, so like that #include, they should
> be outside #ifdef protection.
>
> They also need to be #undefed before defining, in case multiple trace
> headers are included by the same C file. This became the case on
> book3e after commit cf4a6085151a ("powerpc/mm: Add missing tracepoint for
> tlbie"), leading to the following build error:
>
> CC arch/powerpc/kvm/powerpc.o
> In file included from arch/powerpc/kvm/powerpc.c:51:0:
> arch/powerpc/kvm/trace.h:9:0: error: "TRACE_INCLUDE_PATH" redefined
> [-Werror]
> #define TRACE_INCLUDE_PATH .
> ^
> In file included from arch/powerpc/kvm/../mm/mmu_decl.h:25:0,
> from arch/powerpc/kvm/powerpc.c:48:
> ./arch/powerpc/include/asm/trace.h:224:0: note: this is the location of
> the previous definition
> #define TRACE_INCLUDE_PATH asm
> ^
> cc1: all warnings being treated as errors
>
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Scott Wood <oss@buserror.net>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/28c5bcf74fa07c25d5bd118d127192
cheers
prev parent reply other threads:[~2018-11-07 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 1:49 [PATCH] KVM: PPC: Move and undef TRACE_INCLUDE_PATH/FILE Scott Wood
2018-11-07 14:19 ` Naveen N. Rao
2018-11-07 21:27 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42qzz75NZpz9sCs@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=agraf@suse.de \
--cc=chzigotzky@xenosoft.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).