From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Dan Malek <dan@embeddededge.com>
Cc: Kumar Gala <galak@freescale.com>,
linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [RFC][PATCH] [1/2] 8xx platform definitions
Date: Fri, 19 Aug 2005 19:12:53 +0400 [thread overview]
Message-ID: <4305F6F5.6060008@ru.mvista.com> (raw)
In-Reply-To: <6c1a48b29ad7e3d4c7f830f14ee7333d@embeddededge.com>
Dan Malek wrote:
>
> On Aug 19, 2005, at 8:44 AM, Vitaly Bordug wrote:
>
>> +#define MPC8xx_INT_FEC1 SIU_LEVEL1
>> +#define MPC8xx_INT_FEC2 SIU_LEVEL3
>> +
>> +#define MPC8xx_INT_SCC1 (CPM_IRQ_OFFSET + CPMVEC_SCC1)
>> +#define MPC8xx_INT_SCC2 (CPM_IRQ_OFFSET + CPMVEC_SCC2)
>> +#define MPC8xx_INT_SCC3 (CPM_IRQ_OFFSET + CPMVEC_SCC3)
>> +#define MPC8xx_INT_SCC4 (CPM_IRQ_OFFSET + CPMVEC_SCC4)
>> +#define MPC8xx_INT_SMC1 (CPM_IRQ_OFFSET + CPMVEC_SMC1)
>> +#define MPC8xx_INT_SMC2 (CPM_IRQ_OFFSET + CPMVEC_SMC2)
>> +
>> +/* Offset from IMMAP base address */
>> +#define MPC8xx_SCC1_OFFSET (0xa00)
>> +#define MPC8xx_SCC1_SIZE (0x18)
>> +#define MPC8xx_SCC2_OFFSET (0xa20)
>> +#define MPC8xx_SCC2_SIZE (0x18)
>> +#define MPC8xx_SCC3_OFFSET (0xa40)
>> +#define MPC8xx_SCC3_SIZE (0x18)
>> +#define MPC8xx_SCC4_OFFSET (0xa60)
>> +#define MPC8xx_SCC4_SIZE (0x18)
>> +#define MPC8xx_SMC1_OFFSET (0xa82)
>> +#define MPC8xx_SMC1_SIZE (0x0f)
>> +#define MPC8xx_SMC2_OFFSET (0xa92)
>> +#define MPC8xx_SMC2_SIZE (0x0d)
>> +#define MPC8xx_FEC1_OFFSET (0xe00)
>> +#define MPC8xx_FEC1_SIZE (0x88)
>> +#define MPC8xx_FEC2_OFFSET (0x1e00)
>> +#define MPC8xx_FEC2_SIZE (0x88)
>> +
>> +#define MPC8xx_DPARAM_SCC1_OFFSET (0x3C00)
>> +#define MPC8xx_DPARAM_SCC1_SIZE (0x80)
>> +#define MPC8xx_DPARAM_SCC2_OFFSET (0x3D00)
>> +#define MPC8xx_DPARAM_SCC2_SIZE (0x80)
>> +#define MPC8xx_DPARAM_SCC3_OFFSET (0x3E00)
>> +#define MPC8xx_DPARAM_SCC3_SIZE (0x80)
>> +#define MPC8xx_DPARAM_SCC4_OFFSET (0x3F00)
>> +#define MPC8xx_DPARAM_SCC4_SIZE (0x80)
>> +#define MPC8xx_DPARAM_SMC1_OFFSET (0x3E80)
>> +#define MPC8xx_DPARAM_SMC1_SIZE (0x40)
>> +#define MPC8xx_DPARAM_SMC2_OFFSET (0x3F80)
>> +#define MPC8xx_DPARAM_SMC2_SIZE (0x40)
>
>
> All of these #defines should already be in a header file somewhere,
> and if they aren't, should be in the generic CPM header file.
> Please clean this up.
>
> Thanks.
>
> -- Dan
>
>
I am going to move interrupts to the generic CPM header file, others I
guess may be cleanup'ed, with replace respective defines in the source
by pure numbers (as was done previously for PQ2 platform stuff).
--
Sincerely,
Vitaly
next prev parent reply other threads:[~2005-08-19 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-19 12:44 [RFC][PATCH] [1/2] 8xx platform definitions Vitaly Bordug
2005-08-19 15:06 ` Dan Malek
2005-08-19 15:12 ` Vitaly Bordug [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-08-19 13:11 Schaefer-Hutter, Peter
2005-08-19 13:14 ` Vitaly Bordug
2005-08-19 13:31 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4305F6F5.6060008@ru.mvista.com \
--to=vbordug@ru.mvista.com \
--cc=dan@embeddededge.com \
--cc=galak@freescale.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).