From: Daniel Drake <dsd@gentoo.org>
To: Stelian Pop <stelian@popies.net>
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@hp.com>,
linuxppc-dev@ozlabs.org
Subject: Re: 2.6.13-rc7-git2 crashes on iBook
Date: Thu, 01 Sep 2005 20:26:28 +0100 [thread overview]
Message-ID: <431755E4.70703@gentoo.org> (raw)
In-Reply-To: <1125311951.4662.3.camel@localhost.localdomain>
Hi,
Stelian Pop wrote:
> Confirmed on an Apple Powerbook too.
>
> For reference, the (already reverted) patch which needs to be applied is
> below.
>
> Signed-off-by: Stelian Pop <stelian@popies.net>
>
> Index: linux-2.6.git/drivers/pci/setup-res.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/pci/setup-res.c 2005-08-29 10:03:00.000000000 +0200
> +++ linux-2.6.git/drivers/pci/setup-res.c 2005-08-29 12:23:20.980716336 +0200
> @@ -53,9 +53,7 @@
> if (resno < 6) {
> reg = PCI_BASE_ADDRESS_0 + 4 * resno;
> } else if (resno == PCI_ROM_RESOURCE) {
> - if (!(res->flags & IORESOURCE_ROM_ENABLE))
> - return;
> - new |= PCI_ROM_ADDRESS_ENABLE;
> + new |= res->flags & IORESOURCE_ROM_ENABLE;
> reg = dev->rom_base_reg;
> } else {
> /* Hmm, non-standard resource. */
>
Sorry for my ignorance. Which tree was this reverted in? You are probably
aware that this bug made it into 2.6.13 (patch was not reverted there).
Daniel
next prev parent reply other threads:[~2005-09-01 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-28 11:20 2.6.13-rc7-git2 crashes on iBook Andreas Schwab
2005-08-28 18:17 ` Jean Delvare
2005-08-29 4:02 ` Alex Williamson
2005-08-29 10:39 ` Stelian Pop
2005-09-01 19:26 ` Daniel Drake [this message]
2005-09-01 19:54 ` Stelian Pop
2005-08-29 10:56 ` 2.6.13 PowerBook boot hang (was Re: 2.6.13-rc7-git2 crashes on iBook) Sean Neakums
2005-08-29 18:17 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431755E4.70703@gentoo.org \
--to=dsd@gentoo.org \
--cc=alex.williamson@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=stelian@popies.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).