MPC8xx support in 2.6 and [PATCH] USB host controller selection...

MPC8xx support in 2.6 and [PATCH] USB host controller selection...

[David Jander]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]


Hi all,

I am trying to figure out if kernel-2.6.x is already a (stable) option for 
MPC8xx processors. Any hints? experience?
I just rsynced DENX's git tree (cg-clone will crash on a 404 error).
Problems I have found until now:

- Processor identification is still shady. Thanks to Marcello's patch 
yesterday, it now boots up without problems, but this definitely needs to be 
done. Who is working on this part?

- USB Kconfig file for 2.6 kernel is broken. It is not correct to assume that 
you either have a PCI interface or a processor with internal HCI. Proof: We 
have a board based on MPC852T (no internal UHCI) which can plug into an 
(optional) daughter board with a ISP1160 on it. See attached patch.

Maybe the patch should be sent elsewere since it has not much to do with PPC, 
so can someone please tell me where?

Greetings,

-- 
David Jander

[-- Attachment #2: usb-hcd-selection.patch --]
[-- Type: text/x-diff, Size: 1111 bytes --]

--- drivers/usb/Kconfig.old	2005-10-27 14:26:03.701868944 +0200
+++ drivers/usb/Kconfig	2005-10-27 14:26:37.729695928 +0200
@@ -4,37 +4,9 @@
 
 menu "USB support"
 
-# Host-side USB depends on having a host controller
-# NOTE:  dummy_hcd is always an option, but it's ignored here ...
-# NOTE:  SL-811 option should be board-specific ...
-config USB_ARCH_HAS_HCD
-	boolean
-	default y if USB_ARCH_HAS_OHCI
-	default y if ARM				# SL-811
-	default PCI
-
-# many non-PCI SOC chips embed OHCI
-config USB_ARCH_HAS_OHCI
-	boolean
-	# ARM:
-	default y if SA1111
-	default y if ARCH_OMAP
-	default y if ARCH_LH7A404
-	default y if ARCH_S3C2410
-	default y if PXA27x
-	# PPC:
-	default y if STB03xxx
-	default y if PPC_MPC52xx
-	default y if 440EP
-	# MIPS:
-	default y if SOC_AU1X00
-	# more:
-	default PCI
-
 # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface.
 config USB
 	tristate "Support for Host-side USB"
-	depends on USB_ARCH_HAS_HCD
 	---help---
 	  Universal Serial Bus (USB) is a specification for a serial bus
 	  subsystem which offers higher speeds and more features than the

Re: MPC8xx support in 2.6 and [PATCH] USB host controller selection...

[Vitaly Bordug]

David Jander wrote:
> Hi all,
> 
> I am trying to figure out if kernel-2.6.x is already a (stable) option for 
> MPC8xx processors. Any hints? experience?
What option do you mean? The last kernel supports a number of 8xx, and I 
have MPC885ADS and MPC866ADS run it without major problems.
> I just rsynced DENX's git tree (cg-clone will crash on a 404 error).
> Problems I have found until now:
> 
> - Processor identification is still shady. Thanks to Marcello's patch 
> yesterday, it now boots up without problems, but this definitely needs to be 
> done. Who is working on this part?
> 
The fix is in the mm tree. And it has been submitted here as well btw.
> - USB Kconfig file for 2.6 kernel is broken. It is not correct to assume that 
> you either have a PCI interface or a processor with internal HCI. Proof: We 
> have a board based on MPC852T (no internal UHCI) which can plug into an 
> (optional) daughter board with a ISP1160 on it. See attached patch.
> 
> Maybe the patch should be sent elsewere since it has not much to do with PPC, 
> so can someone please tell me where?
I guess linux-usb-devel@lists.sourceforge.net is the correct place to 
issue this.

> 
> Greetings,
> 
> 
> 
> ------------------------------------------------------------------------
> 
> --- drivers/usb/Kconfig.old	2005-10-27 14:26:03.701868944 +0200
> +++ drivers/usb/Kconfig	2005-10-27 14:26:37.729695928 +0200
> @@ -4,37 +4,9 @@
>  
>  menu "USB support"
>  
> -# Host-side USB depends on having a host controller
> -# NOTE:  dummy_hcd is always an option, but it's ignored here ...
> -# NOTE:  SL-811 option should be board-specific ...
> -config USB_ARCH_HAS_HCD
> -	boolean
> -	default y if USB_ARCH_HAS_OHCI
> -	default y if ARM				# SL-811
> -	default PCI
> -
> -# many non-PCI SOC chips embed OHCI
> -config USB_ARCH_HAS_OHCI
> -	boolean
> -	# ARM:
> -	default y if SA1111
> -	default y if ARCH_OMAP
> -	default y if ARCH_LH7A404
> -	default y if ARCH_S3C2410
> -	default y if PXA27x
> -	# PPC:
> -	default y if STB03xxx
> -	default y if PPC_MPC52xx
> -	default y if 440EP
> -	# MIPS:
> -	default y if SOC_AU1X00
> -	# more:
> -	default PCI
> -
>  # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface.
>  config USB
>  	tristate "Support for Host-side USB"
> -	depends on USB_ARCH_HAS_HCD
>  	---help---
>  	  Universal Serial Bus (USB) is a specification for a serial bus
>  	  subsystem which offers higher speeds and more features than the
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded


-- 
Sincerely,
Vitaly

Re: MPC8xx support in 2.6 and [PATCH] USB host controller selection...

[Wolfgang Denk]

In message <200510271439.48990.david.jander@protonic.nl> you wrote:
> 
> I am trying to figure out if kernel-2.6.x is already a (stable) option for 
> MPC8xx processors. Any hints? experience?
> I just rsynced DENX's git tree (cg-clone will crash on a 404 error).

Make sure to use current versions of git resp. cogito.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Every program has at least one bug and can be shortened by  at  least
one instruction - from which, by induction, one can deduce that every
program can be reduced to one instruction which doesn't work.

Re: MPC8xx support in 2.6 and [PATCH] USB host controller selection...

[Jeff Angielski]

On Thu, 2005-10-27 at 15:47 +0200, Wolfgang Denk wrote:
> In message <200510271439.48990.david.jander@protonic.nl> you wrote:
> > 
> > I am trying to figure out if kernel-2.6.x is already a (stable) option for 
> > MPC8xx processors. Any hints? experience?
> > I just rsynced DENX's git tree (cg-clone will crash on a 404 error).
> 
> Make sure to use current versions of git resp. cogito.

I get the same errors using using the latest versions: git version
0.99.8f and cogito-0.15.  FWIW, the u-boot.git came down just fine.


> cg-clone http://www.denx.de/git/linux-2.6-denx.git linux-2.6-denx
defaulting to local storage area
10:24:51 URL:http://www.denx.de/git/linux-2.6-denx.git/HEAD [41/41] ->
"refs/heads/.origin-fetching" [1]
progress: 1 objects, 264 bytes
walk b2304e619029b177db18dc771f2b9ba8cd273b81
progress: 3 objects, 1180 bytes
walk cb7f6ec5c2d64db78984188461dc29b72e924180
progress: 4 objects, 1424 bytes
error: The requested URL returned error: 404
Getting pack list
error: The requested URL returned error: 404
Getting alternates list
error: Unable to find ca442d313d86dc67e0a2e5d584b465bd382cbf5c under
http://www.denx.de/git/linux-2.6-denx.git/

Cannot obtain needed blob ca442d313d86dc67e0a2e5d584b465bd382cbf5c
while processing commit cb7f6ec5c2d64db78984188461dc29b72e924180.
cg-fetch: objects fetch failed
cg-clone: fetch failed


Jeff Angielski
The PTR Group

Re: MPC8xx support in 2.6 and [PATCH] USB host controller selection...

[Wolfgang Denk]

In message <1130423323.8477.24.camel@nighteyes.site> you wrote:
>
> > > I just rsynced DENX's git tree (cg-clone will crash on a 404 error).
> > 
> > Make sure to use current versions of git resp. cogito.
> 
> I get the same errors using using the latest versions: git version
> 0.99.8f and cogito-0.15.  FWIW, the u-boot.git came down just fine.
...
> Cannot obtain needed blob ca442d313d86dc67e0a2e5d584b465bd382cbf5c
> while processing commit cb7f6ec5c2d64db78984188461dc29b72e924180.
> cg-fetch: objects fetch failed
> cg-clone: fetch failed

Don't know what that means.  Accessing  the  tree  using  rsync://...
works fine.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
An expert is a person who avoids the small errors while  sweeping  on
to the grand fallacy.

Re: MPC8xx support in 2.6 and [PATCH] USB host controller selection...

[Marcelo Tosatti]

Greg, please refer to the end of the message.

On Thu, Oct 27, 2005 at 02:39:48PM +0200, David Jander wrote:
> 
> Hi all,
> 
> I am trying to figure out if kernel-2.6.x is already a (stable) option for 
> MPC8xx processors. Any hints? experience?

We're using v2.6.11 on production (with a custom board). Has survived
internal QA procedure, which took a couple of months under various
stress tests.

> I just rsynced DENX's git tree (cg-clone will crash on a 404 error).
> Problems I have found until now:
> 
> - Processor identification is still shady. Thanks to Marcello's patch 
> yesterday, it now boots up without problems, but this definitely needs to be 
> done. Who is working on this part?

Vitaly, can you please push your patch upstream now that v2.6.14 is out?

> - USB Kconfig file for 2.6 kernel is broken. It is not correct to assume that 
> you either have a PCI interface or a processor with internal HCI. Proof: We 
> have a board based on MPC852T (no internal UHCI) which can plug into an 
> (optional) daughter board with a ISP1160 on it. See attached patch.

Is it driven by the UHCI driver?

>From http://www.semiconductors.philips.com/cgi-bin/pldb/pip/isp1160.html

The ISP1160 is an embedded Universal Serial Bus (USB) Host Controller
(HC) that complies with Universal Serial Bus Specification Rev. 2.0,
supporting data transfer at full-speed (12 Mbit/s) and low-speed (1.5
Mbit/s).

> Maybe the patch should be sent elsewere since it has not much to do with PPC, 
> so can someone please tell me where?

I guess that you should have something like

config USB_ARCH_HAS_HCD
	default y if USB_ARCH_HAS_OHCI
	default y if USB_ARCH_HAS_UHCI

config USB_ARCH_UHCI
	default y if 8xx

Greg?

> Greetings,
> 
> -- 
> David Jander

> --- drivers/usb/Kconfig.old	2005-10-27 14:26:03.701868944 +0200
> +++ drivers/usb/Kconfig	2005-10-27 14:26:37.729695928 +0200
> @@ -4,37 +4,9 @@
>  
>  menu "USB support"
>  
> -# Host-side USB depends on having a host controller
> -# NOTE:  dummy_hcd is always an option, but it's ignored here ...
> -# NOTE:  SL-811 option should be board-specific ...
> -config USB_ARCH_HAS_HCD
> -	boolean
> -	default y if USB_ARCH_HAS_OHCI
> -	default y if ARM				# SL-811
> -	default PCI
> -
> -# many non-PCI SOC chips embed OHCI
> -config USB_ARCH_HAS_OHCI
> -	boolean
> -	# ARM:
> -	default y if SA1111
> -	default y if ARCH_OMAP
> -	default y if ARCH_LH7A404
> -	default y if ARCH_S3C2410
> -	default y if PXA27x
> -	# PPC:
> -	default y if STB03xxx
> -	default y if PPC_MPC52xx
> -	default y if 440EP
> -	# MIPS:
> -	default y if SOC_AU1X00
> -	# more:
> -	default PCI
> -
>  # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface.
>  config USB
>  	tristate "Support for Host-side USB"
> -	depends on USB_ARCH_HAS_HCD
>  	---help---
>  	  Universal Serial Bus (USB) is a specification for a serial bus
>  	  subsystem which offers higher speeds and more features than the

Re: MPC8xx support in 2.6 and [PATCH] USB host controller selection...

[Greg KH]

On Fri, Oct 28, 2005 at 01:21:09PM -0200, Marcelo Tosatti wrote:
> Greg, please refer to the end of the message.
> > - USB Kconfig file for 2.6 kernel is broken. It is not correct to assume that 
> > you either have a PCI interface or a processor with internal HCI. Proof: We 
> > have a board based on MPC852T (no internal UHCI) which can plug into an 
> > (optional) daughter board with a ISP1160 on it. See attached patch.

Then please send the proper patch to the linux-usb-devel mailing list.

> Is it driven by the UHCI driver?

It shouldn't be :)

> >From http://www.semiconductors.philips.com/cgi-bin/pldb/pip/isp1160.html
> 
> The ISP1160 is an embedded Universal Serial Bus (USB) Host Controller
> (HC) that complies with Universal Serial Bus Specification Rev. 2.0,
> supporting data transfer at full-speed (12 Mbit/s) and low-speed (1.5
> Mbit/s).

We already have a driver for this device in the kernel tree, right?

> > Maybe the patch should be sent elsewere since it has not much to do with PPC, 
> > so can someone please tell me where?
> 
> I guess that you should have something like
> 
> config USB_ARCH_HAS_HCD
> 	default y if USB_ARCH_HAS_OHCI
> 	default y if USB_ARCH_HAS_UHCI
> 
> config USB_ARCH_UHCI
> 	default y if 8xx
> 
> Greg?

I don't understand what you are trying to fix up here.  What is wrong
with the current checks?  If your arch/board has support for the 1160
and we have the Kconfig set wrong for that, we can easily change it.

thanks,

greg k-h