From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id DDCE4DDE09 for ; Thu, 4 Oct 2007 08:11:02 +1000 (EST) In-Reply-To: References: <87lkakxky1.fsf@macbook.be.48ers.dk> <874ph8xjz1.fsf@macbook.be.48ers.dk> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <436E14BA-FDF5-4F7A-A504-E28B38FA8A67@kernel.crashing.org> From: Kumar Gala Subject: Re: [PATCH] fsl_spi_init: Support non-QE processors Date: Wed, 3 Oct 2007 17:11:05 -0500 To: Peter Korsgaard Cc: "linuxppc-dev@ozlabs.org list" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Oct 3, 2007, at 1:17 PM, Grant Likely wrote: > On 10/3/07, Peter Korsgaard wrote: >>>>>>> "Grant" == Grant Likely writes: >> >> Hi, >> >> Grant> Why not just: >> >> Grant> np = of_find_node_by_type(NULL, "qe"); >> Grant> + if (!np) >> Grant> + np = of_find_node_by_type(NULL, "soc"); >> Grant> if (!np) >> Grant> return -ENODEV; >> >> My first iteration did it like that, but then you don't get a -ENODEV >> if the node is missing (and you'll end up using the wrong clock) and >> it doesn't support processors with SPI on and off QE (if that >> exists/will ever exist). > > Okay, but you should at least be able confine your determination of > which sysclk value to use to one part of the function. Otherwise, it > looks good. Peter, can you respin this w/Grant's modification. I've grabbed the other patches and applied them. waiting on this one. - k