linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* PVR wrong for mpc8343 chips.
@ 2005-11-17 21:54 David Updegraff
  2005-11-17 23:01 ` Kumar Gala
  0 siblings, 1 reply; 2+ messages in thread
From: David Updegraff @ 2005-11-17 21:54 UTC (permalink / raw)
  To: linux-ppc-embedded

[-- Attachment #1: Type: text/plain, Size: 69 bytes --]

Hi.

The PVRs are wrongly enumerated for the 8343/8343e chips.

-dbu

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1575 bytes --]

diff --git a/arch/ppc/syslib/mpc83xx_sys.c b/arch/ppc/syslib/mpc83xx_sys.c
index 29aa633..556b233 100644
--- a/arch/ppc/syslib/mpc83xx_sys.c
+++ b/arch/ppc/syslib/mpc83xx_sys.c
@@ -69,29 +69,53 @@ struct ppc_sys_spec ppc_sys_specs[] = {
 		},
 	},
 	{
-		.ppc_sys_name	= "8343E",
+		.ppc_sys_name	= "8347E",
 		.mask 		= 0xFFFF0000,
 		.value 		= 0x80540000,
-		.num_devices	= 7,
+		.num_devices	= 8,
 		.device_list	= (enum ppc_sys_devices[])
 		{
 			MPC83xx_TSEC1, MPC83xx_TSEC2, MPC83xx_IIC1,
 			MPC83xx_IIC2, MPC83xx_DUART, MPC83xx_SEC2,
-			MPC83xx_USB2_DR,
+			MPC83xx_USB2_DR, MPC83xx_USB2_MPH
 		},
 	},
 	{
-		.ppc_sys_name	= "8343",
+		.ppc_sys_name	= "8347",
 		.mask 		= 0xFFFF0000,
 		.value 		= 0x80550000,
-		.num_devices	= 6,
+		.num_devices	= 7,
 		.device_list	= (enum ppc_sys_devices[])
 		{
 			MPC83xx_TSEC1, MPC83xx_TSEC2, MPC83xx_IIC1,
 			MPC83xx_IIC2, MPC83xx_DUART,
-			MPC83xx_USB2_DR,
+			MPC83xx_USB2_DR, MPC83xx_USB2_MPH
 		},
 	},
+	{
+		.ppc_sys_name	= "8343E",
+		.mask 		= 0xFFFF0000,
+		.value 		= 0x80560000,
+		.num_devices	= 7,
+		.device_list	= (enum ppc_sys_devices[])
+		{
+			MPC83xx_TSEC1, MPC83xx_TSEC2, MPC83xx_IIC1,
+			MPC83xx_IIC2, MPC83xx_DUART, MPC83xx_SEC2,
+			MPC83xx_USB2_DR
+		}
+	},
+	{
+		.ppc_sys_name	= "8343",
+		.mask 		= 0xFFFF0000,
+		.value 		= 0x80570000,
+		.num_devices	= 6,
+		.device_list	= (enum ppc_sys_devices[])
+		{
+			MPC83xx_TSEC1, MPC83xx_TSEC2, MPC83xx_IIC1,
+			MPC83xx_IIC2, MPC83xx_DUART,
+			MPC83xx_USB2_DR
+		}
+	},
 	{	/* default match */
 		.ppc_sys_name	= "",
 		.mask 		= 0x00000000,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: PVR wrong for mpc8343 chips.
  2005-11-17 21:54 PVR wrong for mpc8343 chips David Updegraff
@ 2005-11-17 23:01 ` Kumar Gala
  0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2005-11-17 23:01 UTC (permalink / raw)
  To: David Updegraff; +Cc: linux-ppc-embedded

On Thu, 17 Nov 2005, David Updegraff wrote:

> Hi.
> 
> The PVRs are wrongly enumerated for the 8343/8343e chips.
> 
> -dbu

Good catch.  I'll send a fixed up version of this patch upstream.

In the future take a look at Documentation/SubmittingPatches.

thanks

- kumar

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-11-17 23:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-17 21:54 PVR wrong for mpc8343 chips David Updegraff
2005-11-17 23:01 ` Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).