From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Michael Neuling To: Timur Tabi Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port In-reply-to: References: <20100308191005.GE4324@amak.tundra.com> Date: Tue, 03 Aug 2010 16:06:30 +1000 Message-ID: <4381.1280815590@neuling.org> Cc: Alexandre Bounine , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, thomas.moll@sysgo.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > > MCSR_MASK is not defined anywhere, so when I compile this code, I get this: > > Never mind. I see that it's been fixed already, and that the patch > that removed MCSR_MASK was posted around the same time that this patch > was posted. I don't know what happened here but 2.6.35 is broken because of this problem: arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared (first use in this function) arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier is reported only once arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears in.) arch/powerpc/sysdev/fsl_rio.c:250: error: 'MCSR_BUS_RBERR' undeclared (first use in this function) Mikey