linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: olof@lixom.net (Olof Johansson)
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] DMA 4GB boundary protection
Date: Thu, 22 Mar 2007 23:52:02 +0100	[thread overview]
Message-ID: <438dfe13f572740e899f10b6219b6833@kernel.crashing.org> (raw)
In-Reply-To: <20070322175324.GA21120@lixom.net>

> I would also like it to be the last page in the range, not the first
> (since otherwise you'll reserve even if the window is less than 4GB.
>
> Something like (untested):
>
> 	entries_per_4g = 0x100000000 >> IOMMU_PAGE_SHIFT;
>
> 	/* Mark the last bit before a 4GB boundary as used */
> 	start_index = tbl->it_offset | (entries_per_4g - 1);
> 	end_index = tbl->it_offset + tbl->it_size;
>
> 	for (index = start_index; index < end_index; index += entries_per_4g)
> 		__set_bit(index, tbl->it_map);

As a very minor optimisation, avoid reserving the last page
of the I/O window if it ends on a 4GB boundary?


Segher

  parent reply	other threads:[~2007-03-22 22:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-02 21:49 [PATCH] DMA 4GB boundary protection Jake Moilanen
2007-03-02 22:27 ` Olof Johansson
2007-03-03  8:27   ` Benjamin Herrenschmidt
2007-03-03 23:25     ` Olof Johansson
2007-03-04  5:17     ` Christoph Hellwig
2007-03-04  5:52       ` Olof Johansson
2007-03-03 23:29 ` Olof Johansson
2007-03-03 23:32   ` Segher Boessenkool
2007-03-03 23:57     ` Olof Johansson
2007-03-21 21:05   ` Jake Moilanen
2007-03-21 21:39     ` Olof Johansson
2007-03-22 17:53     ` Olof Johansson
2007-03-22 17:47       ` Jake Moilanen
2007-03-22 22:52       ` Segher Boessenkool [this message]
2007-03-27 20:10       ` Jake Moilanen
2007-03-27 20:55         ` Benjamin Herrenschmidt
2007-03-27 23:48         ` Paul Mackerras
2007-03-28 15:56         ` Olof Johansson
2007-03-28 18:17           ` Jake Moilanen
2007-03-28 23:23             ` Benjamin Herrenschmidt
2007-03-29 13:44               ` Jake Moilanen
2007-03-29 14:52                 ` Olof Johansson
2007-03-29 21:54                 ` Benjamin Herrenschmidt
2007-04-23 12:22                 ` Paul Mackerras
2007-04-24  3:07                   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438dfe13f572740e899f10b6219b6833@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).