From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Matthew McClintock <msm@freescale.com>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] ppc32: Adds MPC885ADS, MPC866ADS and MPC8272ADS-specific platform stuff for fs_enet
Date: Thu, 08 Dec 2005 16:40:36 +0300 [thread overview]
Message-ID: <439837D4.7090304@ru.mvista.com> (raw)
In-Reply-To: <1133848163.7932.2.camel@localhost.localdomain>
Matt,
Matthew McClintock wrote:
> On Mon, 2005-11-28 at 10:00 -0700, Vitaly Bordug wrote:
>> + mpc82xx_fcc1_pdata.dpram_offset =
>> mpc82xx_fcc2_pdata.dpram_offset = (u32)cpm2_immr->im_dprambase;
>> + mpc82xx_fcc1_pdata.fcc_regs_c = mpc82xx_fcc2_pdata.fcc_regs_c
>> = (u32)cpm2_immr->im_fcc_c;
>
> I'm not sure if this has already been discussed, but what is stopping us
> from including this in the platform definition files along with the
> other offsets?
IIRC, because these values could vary along the PQ2 family, when all the stuff in pq2_devices.c should be static and applicable to any PQ2 which does have the corresponding device.
>
> -Matthew
>
>
--
Sincerely,
Vitaly
next prev parent reply other threads:[~2005-12-08 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-28 17:00 [PATCH] ppc32: Adds MPC885ADS, MPC866ADS and MPC8272ADS-specific platform stuff for fs_enet Vitaly Bordug
2005-11-28 14:48 ` Marcelo Tosatti
2005-11-29 10:07 ` Ingo Hornberger
2005-11-29 10:25 ` Vitaly Bordug
2005-12-06 5:49 ` Matthew McClintock
2005-12-08 13:40 ` Vitaly Bordug [this message]
2005-12-08 16:14 ` Kumar Gala
2005-12-06 17:13 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439837D4.7090304@ru.mvista.com \
--to=vbordug@ru.mvista.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=msm@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).