From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [v3] powerpc: implement CONFIG_DEBUG_VIRTUAL
Date: Sat, 22 Dec 2018 20:54:52 +1100 (AEDT) [thread overview]
Message-ID: <43MLSs1wdzz9sPT@ozlabs.org> (raw)
In-Reply-To: <a42260e77d609a10667872c2e7bf14ceabcce050.1544562518.git.christophe.leroy@c-s.fr>
On Tue, 2018-12-11 at 22:40:53 UTC, Christophe Leroy wrote:
> This patch implements CONFIG_DEBUG_VIRTUAL to warn about
> incorrect use of virt_to_phys() and page_to_phys()
>
> Below is the result of test_debug_virtual:
>
> [ 1.438746] WARNING: CPU: 0 PID: 1 at ./arch/powerpc/include/asm/io.h:808 test_debug_virtual_init+0x3c/0xd4
> [ 1.448156] CPU: 0 PID: 1 Comm: swapper Not tainted 4.20.0-rc5-00560-g6bfb52e23a00-dirty #532
> [ 1.457259] NIP: c066c550 LR: c0650ccc CTR: c066c514
> [ 1.462257] REGS: c900bdb0 TRAP: 0700 Not tainted (4.20.0-rc5-00560-g6bfb52e23a00-dirty)
> [ 1.471184] MSR: 00029032 <EE,ME,IR,DR,RI> CR: 48000422 XER: 20000000
> [ 1.477811]
> [ 1.477811] GPR00: c0650ccc c900be60 c60d0000 00000000 006000c0 c9000000 00009032 c7fa0020
> [ 1.477811] GPR08: 00002400 00000001 09000000 00000000 c07b5d04 00000000 c00037d8 00000000
> [ 1.477811] GPR16: 00000000 00000000 00000000 00000000 c0760000 c0740000 00000092 c0685bb0
> [ 1.477811] GPR24: c065042c c068a734 c0685b8c 00000006 00000000 c0760000 c075c3c0 ffffffff
> [ 1.512711] NIP [c066c550] test_debug_virtual_init+0x3c/0xd4
> [ 1.518315] LR [c0650ccc] do_one_initcall+0x8c/0x1cc
> [ 1.523163] Call Trace:
> [ 1.525595] [c900be60] [c0567340] 0xc0567340 (unreliable)
> [ 1.530954] [c900be90] [c0650ccc] do_one_initcall+0x8c/0x1cc
> [ 1.536551] [c900bef0] [c0651000] kernel_init_freeable+0x1f4/0x2cc
> [ 1.542658] [c900bf30] [c00037ec] kernel_init+0x14/0x110
> [ 1.547913] [c900bf40] [c000e1d0] ret_from_kernel_thread+0x14/0x1c
> [ 1.553971] Instruction dump:
> [ 1.556909] 3ca50100 bfa10024 54a5000e 3fa0c076 7c0802a6 3d454000 813dc204 554893be
> [ 1.564566] 7d294010 7d294910 90010034 39290001 <0f090000> 7c3e0b78 955e0008 3fe0c062
> [ 1.572425] ---[ end trace 6f6984225b280ad6 ]---
> [ 1.577467] PA: 0x09000000 for VA: 0xc9000000
> [ 1.581799] PA: 0x061e8f50 for VA: 0xc61e8f50
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6bf752daca07c85c181159f75dcf65
cheers
prev parent reply other threads:[~2018-12-22 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 22:40 [PATCH v3] powerpc: implement CONFIG_DEBUG_VIRTUAL Christophe Leroy
2018-12-12 0:23 ` Michael Ellerman
2018-12-12 7:19 ` Christophe Leroy
2018-12-12 10:35 ` Michael Ellerman
2018-12-18 14:06 ` Michael Ellerman
2018-12-19 0:26 ` Michael Ellerman
2018-12-19 6:57 ` Christophe Leroy
2018-12-19 7:03 ` Christophe Leroy
2018-12-19 8:04 ` Michael Ellerman
2018-12-22 9:54 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43MLSs1wdzz9sPT@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).