From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73F05C433F5 for ; Fri, 26 Nov 2021 07:14:14 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4J0mFc5vGsz3cSp for ; Fri, 26 Nov 2021 18:14:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kaod.org (client-ip=46.105.45.231; helo=8.mo548.mail-out.ovh.net; envelope-from=clg@kaod.org; receiver=) Received: from 8.mo548.mail-out.ovh.net (8.mo548.mail-out.ovh.net [46.105.45.231]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4J0mF46sQvz2yKN for ; Fri, 26 Nov 2021 18:13:43 +1100 (AEDT) Received: from mxplan5.mail.ovh.net (unknown [10.109.156.216]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id B32A020C67; Fri, 26 Nov 2021 07:13:36 +0000 (UTC) Received: from kaod.org (37.59.142.105) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 26 Nov 2021 08:13:36 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-105G00663584b6d-9fa6-48d3-a7be-6a82937e30d0, B8303126CBA279BD35B7DF0844B381DDFAFB7782) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <43d21c1a-9122-d698-2229-e56c77a91313@kaod.org> Date: Fri, 26 Nov 2021 08:13:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] powerpc/pseries/vas: Don't print an error when VAS is unavailable Content-Language: en-US To: Nicholas Piggin , References: <20211126052133.1664375-1-npiggin@gmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20211126052133.1664375-1-npiggin@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.105] X-ClientProxiedBy: DAG9EX2.mxp5.local (172.16.2.82) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 2aa71378-f39d-486a-9926-18754a4566c3 X-Ovh-Tracer-Id: 9880897584827435997 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrhedugddutdehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtjeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhephffhleegueektdetffdvffeuieeugfekkeelheelteeftdfgtefffeehueegleehnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohephhgrrhgvnheslhhinhhugidrihgsmhdrtghomh X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haren Myneni Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 11/26/21 06:21, Nicholas Piggin wrote: > KVM does not support VAS so guests always print a useless error on boot > > vas: HCALL(398) error -2, query_type 0, result buffer 0x57f2000 > > Change this to only print the message if the error is not H_FUNCTION. Just being curious, why is it even called since "ibm,compression" should not be exposed in the DT ? C. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/platforms/pseries/vas.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/vas.c b/arch/powerpc/platforms/pseries/vas.c > index b043e3936d21..734523e2272f 100644 > --- a/arch/powerpc/platforms/pseries/vas.c > +++ b/arch/powerpc/platforms/pseries/vas.c > @@ -151,8 +151,15 @@ int h_query_vas_capabilities(const u64 hcall, u8 query_type, u64 result) > if (rc == H_SUCCESS) > return 0; > > - pr_err("HCALL(%llx) error %ld, query_type %u, result buffer 0x%llx\n", > - hcall, rc, query_type, result); > + /* H_FUNCTION means HV does not support VAS so don't print an error */ > + if (rc != H_FUNCTION) { > + pr_err("%s error %ld, query_type %u, result buffer 0x%llx\n", > + (hcall == H_QUERY_VAS_CAPABILITIES) ? > + "H_QUERY_VAS_CAPABILITIES" : > + "H_QUERY_NX_CAPABILITIES", > + rc, query_type, result); > + } > + > return -EIO; > } > EXPORT_SYMBOL_GPL(h_query_vas_capabilities); >