From: Thomas Zimmermann <tzimmermann@suse.de>
To: Michael Ellerman <mpe@ellerman.id.au>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org, Geoff Levand <geoff@infradead.org>,
dri-devel@lists.freedesktop.org,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions
Date: Fri, 9 Feb 2024 21:24:11 +0100 [thread overview]
Message-ID: <43ed64aa-17b0-4d04-a1f3-a6e13f59a743@suse.de> (raw)
In-Reply-To: <8734u28bh8.fsf@mail.lhotse>
Hi
Am 09.02.24 um 06:15 schrieb Michael Ellerman:
> Thomas Zimmermann <tzimmermann@suse.de> writes:
>> Am 07.02.24 um 17:13 schrieb Randy Dunlap:
>>> When VIDEO is not set, there is a build error. Fix that by selecting
>>> VIDEO for PS3_PS3AV.
>>>
>>> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
>>>
>>> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
>>> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>> Cc: Nicholas Piggin <npiggin@gmail.com>
>>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>>> Cc: Aneesh Kumar K.V <aneesh.kumar@kernel.org>
>>> Cc: Naveen N. Rao <naveen.n.rao@linux.ibm.com>
>>> Cc: linuxppc-dev@lists.ozlabs.org
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: Geoff Levand <geoff@infradead.org>
>>> Acked-by: Geoff Levand <geoff@infradead.org>
>>> Cc: linux-fbdev@vger.kernel.org
>>> Cc: dri-devel@lists.freedesktop.org
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> Can you take it via whatever tree the CONFIG_VIDEO patch is in?
The patch is now in drm-misc-next.
Best regards
Thomas
>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>
> cheers
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
prev parent reply other threads:[~2024-02-09 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 16:13 [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions Randy Dunlap
2024-02-07 16:36 ` Thomas Zimmermann
2024-02-09 5:15 ` Michael Ellerman
2024-02-09 20:24 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ed64aa-17b0-4d04-a1f3-a6e13f59a743@suse.de \
--to=tzimmermann@suse.de \
--cc=aneesh.kumar@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geoff@infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).