From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: chunkeey@gmail.com
Subject: Re: powerpc/4xx/ocm: Fix fix for phys_addr_t printf warnings
Date: Thu, 17 Jan 2019 11:27:28 +1100 (AEDT) [thread overview]
Message-ID: <43g4f90795z9sCh@ozlabs.org> (raw)
In-Reply-To: <20190114003255.22005-1-mpe@ellerman.id.au>
On Mon, 2019-01-14 at 00:32:55 UTC, Michael Ellerman wrote:
> My recent commit to fix the printf warnings in ocm.c got the format
> specifier wrong, because I copied it from the documentation without
> realising the square brackets are not meant as literals.
>
> This results in the address being suffixed with a literal "[p]".
>
> Actually tested this time:
>
> # cat info /sys/kernel/debug/ppc4xx_ocm
> PhysAddr : 0x0000000400040000
> ...
> NC.PhysAddr : 0x0000000400040000
> ...
> C.PhysAddr : 0x0000000000000000
>
> Fixes: 52b88fa1e8c7 ("powerpc/4xx/ocm: Fix phys_addr_t printf warnings")
> Reported-by: Christian Lamparter <chunkeey@gmail.com>
> Tested-by: Christian Lamparter <chunkeey@gmail.com>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc fixes.
https://git.kernel.org/powerpc/c/fcf5036f09694d09d946c0455f329894
cheers
prev parent reply other threads:[~2019-01-17 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 0:32 [PATCH] powerpc/4xx/ocm: Fix fix for phys_addr_t printf warnings Michael Ellerman
2019-01-17 0:27 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43g4f90795z9sCh@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=chunkeey@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).