From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 470D0C282CB for ; Tue, 5 Feb 2019 11:32:14 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F08BA20821 for ; Tue, 5 Feb 2019 11:32:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F08BA20821 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43v2VK1gY9zDqHr for ; Tue, 5 Feb 2019 22:32:09 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43v2M05c36zDqHh for ; Tue, 5 Feb 2019 22:25:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 43v2Lz1NKxz9sN9; Tue, 5 Feb 2019 22:25:46 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 5a3840a470c41ec0b85cd36ca80370330656b163 X-Patchwork-Hint: ignore In-Reply-To: <20190131015347.21674-1-oohall@gmail.com> To: Oliver O'Halloran , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: powerpc/papr_scm: Use the correct bind address Message-Id: <43v2Lz1NKxz9sN9@ozlabs.org> Date: Tue, 5 Feb 2019 22:25:46 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oliver O'Halloran , stable@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 2019-01-31 at 01:53:47 UTC, Oliver O'Halloran wrote: > When binding an SCM volume to a physical address the hypervisor has the > option to return early with a continue token with the expectation that > the guest will resume the bind operation until it completes. A quirk of > this interface is that the bind address will only be returned by the > first bind h-call and the subsequent calls will return > 0xFFFF_FFFF_FFFF_FFFF for the bind address. > > We currently do not save the address returned by the first h-call. As a > result we will use the junk address as the base of the bound region if > the hypervisor decides to split the bind across multiple h-calls. This > bug was found when testing with very large SCM volumes where the bind > process would take more time than they hypervisor's internal h-call time > limit would allow. This patch fixes the issue by saving the bind address > from the first call. > > Cc: stable@vger.kernel.org > Fixes: b5beae5e224f ("powerpc/pseries: Add driver for PAPR SCM regions") > Signed-off-by: Oliver O'Halloran Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/5a3840a470c41ec0b85cd36ca8037033 cheers