From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Vaibhav Jain <vaibhav@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Frederic Barrat <fbarrat@linux.ibm.com>
Cc: Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,
Christophe Lombard <clombard@linux.vnet.ibm.com>,
stable@vger.kernel.org, Alastair D'Silva <alastair@linux.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Vaibhav Jain <vaibhav@linux.ibm.com>,
Christophe Lombard <christophe_lombard@fr.ibm.com>
Subject: Re: [RESEND, v3] cxl: Wrap iterations over afu slices inside 'afu_list_lock'
Date: Sat, 9 Feb 2019 00:02:37 +1100 (AEDT) [thread overview]
Message-ID: <43wwML0Kf6z9sNH@ozlabs.org> (raw)
In-Reply-To: <20190129110618.13481-1-vaibhav@linux.ibm.com>
On Tue, 2019-01-29 at 11:06:18 UTC, Vaibhav Jain wrote:
> Within cxl module, iteration over array 'adapter->afu' may be racy
> at few points as it might be simultaneously read during an EEH and its
> contents being set to NULL while driver is being unloaded or unbound
> from the adapter. This might result in a NULL pointer to 'struct afu'
> being de-referenced during an EEH thereby causing a kernel oops.
>
> This patch fixes this by making sure that all access to the array
> 'adapter->afu' is wrapped within the context of spin-lock
> 'adapter->afu_list_lock'.
>
> Cc: stable@vger.kernel.org
> Fixes: 9e8df8a2196("cxl: EEH support")
> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> Acked-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/edeb304f659792fb5bab90d7d6f3408b
cheers
prev parent reply other threads:[~2019-02-08 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 11:06 [RESEND PATCH v3] cxl: Wrap iterations over afu slices inside 'afu_list_lock' Vaibhav Jain
2019-01-30 12:41 ` Michael Ellerman
2019-01-30 13:25 ` Vaibhav Jain
2019-01-30 14:46 ` Sasha Levin
2019-02-08 13:02 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43wwML0Kf6z9sNH@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=alastair@linux.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=christophe_lombard@fr.ibm.com \
--cc=clombard@linux.vnet.ibm.com \
--cc=fbarrat@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=philippe.bergheaud@fr.ibm.com \
--cc=stable@vger.kernel.org \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).