From: Arnd Bergmann <arnd@arndb.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Borislav Petkov <bp@alien8.de>,
dougthompson@xmission.com, mchehab@kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] drivers/edac: NO_IRQ removal from powerpc-only drivers
Date: Mon, 12 Sep 2016 09:36:22 +0200 [thread overview]
Message-ID: <4413035.eY2sIBJ9x6@wuerfel> (raw)
In-Reply-To: <874m5lrafq.fsf@concordia.ellerman.id.au>
On Monday, September 12, 2016 2:47:37 PM CEST Michael Ellerman wrote:
> >> @@ -1058,7 +1058,7 @@ static int mpc85xx_mc_err_probe(struct platform_device *op)
> >>
> >> pdata = mci->pvt_info;
> >> pdata->name = "mpc85xx_mc_err";
> >> - pdata->irq = NO_IRQ;
> >> + pdata->irq = 0;
> >> mci->pdev = &op->dev;
> >> pdata->edac_idx = edac_mc_idx++;
> >> dev_set_drvdata(mci->pdev, mci);
> >
> > That part went into drivers/edac/fsl_ddr_edac.c which is only the
> > freescale memory controller being shared between ARM and PPC, see
> >
> > http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
> >
> > But that shouldn't change the issue wrt ->irq as now it is implicitly 0.
>
> Ah OK.
>
> NO_IRQ is -1 on ARM (or at least it can be?), see arch/arm/include/asm/irq.h.
>
> So I'll leave that one alone for now.
I don't think there is any way to build the mpc85xx on ARM, it depends
on the powerpc-specific "FSL_SOC" symbol and it uses the in_be32/out_be32
MMIO helpers that are not defined on ARM.
I've sent patches to remove all uses of NO_IRQ that happen on ARM.
Please remove this instance too.
Arnd
next prev parent reply other threads:[~2016-09-12 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 9:57 [PATCH] drivers/edac: NO_IRQ removal from powerpc-only drivers Michael Ellerman
2016-09-10 14:53 ` Borislav Petkov
2016-09-12 4:47 ` Michael Ellerman
2016-09-12 7:36 ` Arnd Bergmann [this message]
2016-09-12 9:57 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4413035.eY2sIBJ9x6@wuerfel \
--to=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mchehab@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).