From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arnd@arndb.de>
Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 3sXftN3BStzDsZw
 for <linuxppc-dev@lists.ozlabs.org>; Mon, 12 Sep 2016 17:43:08 +1000 (AEST)
From: Arnd Bergmann <arnd@arndb.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Borislav Petkov <bp@alien8.de>, dougthompson@xmission.com,
 mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
 linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] drivers/edac: NO_IRQ removal from powerpc-only drivers
Date: Mon, 12 Sep 2016 09:36:22 +0200
Message-ID: <4413035.eY2sIBJ9x6@wuerfel>
In-Reply-To: <874m5lrafq.fsf@concordia.ellerman.id.au>
References: <1473501428-8217-1-git-send-email-mpe@ellerman.id.au>
 <20160910145320.bg6s6wo5ya7zzw2n@pd.tnic>
 <874m5lrafq.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

On Monday, September 12, 2016 2:47:37 PM CEST Michael Ellerman wrote:
> >> @@ -1058,7 +1058,7 @@ static int mpc85xx_mc_err_probe(struct platform_device *op)
> >>  
> >>      pdata = mci->pvt_info;
> >>      pdata->name = "mpc85xx_mc_err";
> >> -    pdata->irq = NO_IRQ;
> >> +    pdata->irq = 0;
> >>      mci->pdev = &op->dev;
> >>      pdata->edac_idx = edac_mc_idx++;
> >>      dev_set_drvdata(mci->pdev, mci);
> >
> > That part went into drivers/edac/fsl_ddr_edac.c which is only the
> > freescale memory controller being shared between ARM and PPC, see
> >
> > http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
> >
> > But that shouldn't change the issue wrt ->irq as now it is implicitly 0.
> 
> Ah OK.
> 
> NO_IRQ is -1 on ARM (or at least it can be?), see arch/arm/include/asm/irq.h.
> 
> So I'll leave that one alone for now.

I don't think there is any way to build the mpc85xx on ARM, it depends
on the powerpc-specific "FSL_SOC" symbol and it uses the in_be32/out_be32
MMIO helpers that are not defined on ARM.

I've sent patches to remove all uses of NO_IRQ that happen on ARM.
Please remove this instance too.

	Arnd