From: Haren Myneni <haren@us.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, ellerman@au1.ibm.com,
Milton Miller <miltonm@bga.com>, Olaf Hering <olh@suse.de>
Subject: [PATCH] kdump: clear and EOI IPI for kexec CPU
Date: Wed, 22 Mar 2006 21:18:24 -0800 [thread overview]
Message-ID: <44222FA0.90902@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
Paul, Sorry, Please ignore the previous patch since it has one tab/space
issue. Tested this one and kdump-dma-fault-fix.patch on P5, P4
(non-lpar), JS21 and JS20.
Thanks
Haren
Some times, the kexec CPU is not reponding to an IPI during kdump boot.
It is causing the system in xmon. Noticed on power-4 (non-lpar). This
patch clears and EOI IPI for kexec CPU as well before the kdump boot
started.
Signed-off-by: Haren Myneni <haren@us.ibm.com>
[-- Attachment #2: kdump-clear-IPI.patch --]
[-- Type: text/x-patch, Size: 1162 bytes --]
--- 2616-git5-k1/arch/powerpc/platforms/pseries/xics.c.orig 2006-04-04 19:27:24.000000000 -0700
+++ 2616-git5-k1/arch/powerpc/platforms/pseries/xics.c 2006-04-04 20:06:19.000000000 -0700
@@ -641,22 +641,27 @@ void xics_teardown_cpu(int secondary)
iosync();
/*
+ * Clear IPI
+ */
+ ops->qirr_info(cpu, 0xff);
+ /*
+ * we need to EOI the IPI if we got here from kexec down IPI
+ *
+ * probably need to check all the other interrupts too
+ * should we be flagging idle loop instead?
+ * or creating some task to be scheduled?
+ */
+ ops->xirr_info_set(cpu, XICS_IPI);
+
+ /*
* Some machines need to have at least one cpu in the GIQ,
* so leave the master cpu in the group.
*/
- if (secondary) {
- /*
- * we need to EOI the IPI if we got here from kexec down IPI
- *
- * probably need to check all the other interrupts too
- * should we be flagging idle loop instead?
- * or creating some task to be scheduled?
- */
- ops->xirr_info_set(cpu, XICS_IPI);
+ if (secondary)
rtas_set_indicator(GLOBAL_INTERRUPT_QUEUE,
(1UL << interrupt_server_size) - 1 -
default_distrib_server, 0);
- }
+
}
#ifdef CONFIG_HOTPLUG_CPU
next reply other threads:[~2006-03-23 5:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 5:18 Haren Myneni [this message]
2006-03-27 2:04 ` [PATCH] kdump: clear and EOI IPI for kexec CPU Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44222FA0.90902@us.ibm.com \
--to=haren@us.ibm.com \
--cc=ellerman@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=olh@suse.de \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).